Will this RegEx match any Stack Exchange site?

Question

I have made this RegEx:

/http:\/\/(.+)?\.?(stackoverflow|superuser|serverfault|stackapps|stackexchange)\.com\/questions\/([0-9]+)\/?.*/i

It needs to match any Stack Exchange website's question. Is this the right RegEx? I have tested it and it works, but I've not tested it on all beta-sites and since I know I'm Satan in the RegEx world, I know there is something wrong (there is always something wrong with my RegExes xD).

Is this one good? Thanks.

Answer 1

Are you going to be using it against parties that might be trying to trick it? This could match on the querystring of the url, I would think. (http://badguy.com?http://stackoverflow.com/questions).

A better approach might be to use a URL parsing library or function to extract out the important components safely.

Answer 2

Are you sure you want to do this with a regex? I think it would be better if you stored all the existing sites' urls somwhere and use this list instead. When you use a regex you will need to update it anyway once any of the beta sites goes live and chooses its domain...