views:

101

answers:

3

Android's ProgressDialog allows you to set the current progress and maximum value as integers. These values are shown in the dialog like this:

3401/10023

Where the first number is the current progress, and the second number is the maximum value.

I would like to also show the unit of measurement. Something like this:

3401/10023 KB

Is this possible using ProgressDialog? If not, what do you recommend doing to give this information to the user? I'm trying to avoid reimplementing ProgressDialog just to include the unit.

A: 

Why don't you do it in term of percentages ? Like 30/100

fedj
The progress dialog already shows the percentage. But in a file download progress dialog, I think it's more friendly to the user to show the progress in bytes, specially if it's a large file.
hgpc
If you take a look to ProgressDialog sources, the text is handled by a handler created in the onCreate method. See my next answer
fedj
+1  A: 

In the ProgressDialog source file :

mViewUpdateHandler = new Handler() {
            @Override
            public void handleMessage(Message msg) {
                super.handleMessage(msg);

                /* Update the number and percent */
                int progress = mProgress.getProgress();
                int max = mProgress.getMax();
                double percent = (double) progress / (double) max;
                mProgressNumber.setText(progress + "/" + max);
                mProgressPercent.setText(mProgressPercentFormat.format(percent));
            }
        };

You must reimplement it, you cannot avoid it

fedj
+1 For pointing me towards the source code.
hgpc
A: 

The HEAD of the ProgressDialog source code already includes a public function called setProgressNumberFormat which can be used to set the unit. Unfortunately this function does not seem to be available in the latest Android version. I guess it will be included in a future update.

In the meantime, copying this implementation of ProgressDialog is the best option. Subclassing ProgressDialog is of no use because all of its members are private and working with view.findViewById(R.id.progress_number) to get the TextView directly is extremely risky, as nothing ensures that the id will be always the same (or that the TextView will always exist).

hgpc
Yep but at least 2.3 for the setProgressNumberFormat.The findViewById is not recommended at all, nothing tells you that any actual or future version has the same id
fedj
Agreed. I actually mentioned those possibilities to discourage their use, but I will make it clearer.
hgpc