tags:

views:

263

answers:

3

I want to have two loop variables of different types. Is there any way to make this work?

@Override
public T get(int index) throws IndexOutOfBoundsException {

            // syntax error on first 'int'
    for (Node<T> current = first, int currentIndex; current != null; current = current.next, currentIndex++) {
        if (currentIndex == index) {
            return current.datum;
        }
    }

    throw new IndexOutOfBoundsException();
}

Thanks.

+1  A: 

Just move variable declarations (Node<T> current, int currentIndex) outside the loop and it should work. Something like this

int currentIndex;
Node<T> current;
for (current = first; current != null; current = current.next, currentIndex++) {

or maybe even

int currentIndex;
for (Node<T> current = first; current != null; current = current.next, currentIndex++) {
Nikita Rybak
Neither will compile: you have to initialize variables before use.
unbeli
@unbeli well, I wasn't exercising in manual code compilation :) I just wanted to give the idea.
Nikita Rybak
@unbeli: Just to clarify: currentIndex needs to be initialized. The first thing Nikita does to it is "currentIndex++", which naturally brings up the question, increment what? current is fine because the first use is to set it to first.
Jay
@Jay yes yes yes
unbeli
+4  A: 

You can't like this. Either you use multiple variables of the same type for(Object var1 = null, var2 = null; ...) or you extract the other variable and declare it before the for loop.

Colin Hebert
+2  A: 

The initialization of a for statement follows the rules for local variable declarations.

This would be legal (if silly):

for (int a = 0, b[] = { 1 }, c[][] = { { 1 }, { 2 } }; a < 10; a++) {
  // something
}

But trying to declare the distinct Node and int types as you want is not legal for local variable declarations.

You can limit the scope of additional variables within methods by using a block like this:

{
  int n = 0;
  for (Object o = new Object();/* expr */;/* expr */) {
    // do something
  }
}

This ensures that you don't accidentally reuse the variable elsewhere in the method.

McDowell