ansaurus

Question

Answer 1

+1 A:

Put all details in the logs and show the user only a vague message that something went wrong, regardless of what the exception is. So your error page may look like (to quote twitter):

<%@ page isErrorPage="true" %>

Something went technically wrong.

And do not catch & forward - simply let the exception bubble. The other alternative is, as you say, make two separate pages that include the common content, and differ only in the isErrorPage definition.

Bozho 2010-08-24 08:00:01

but the problem will still be there. when a jsp page is decalared is `isErrorPage` the `javax.servlet.error.status_code` must have something in it or else a Null Pointer Exception is thrown.

Omnipresent 2010-08-24 11:31:49

@Omnipresent - correct. I added an update about that.

Bozho 2010-08-24 11:42:03

@bozho I thought in last question you suggested that if I want to avoid putting exceptions in server.log then I need to catch them and that's the only option. that's why I am now catching it and forwarding.

learn_plsql 2010-08-24 13:23:03

Yes, given the other question (I didn't relate the two initially) then forwarding sounds less bad.

Bozho 2010-08-24 13:28:11

Answer 2

+1 A:

You can create a custom stackTrace jsp tag and include it in a special error page:

The tag file (WEB-INF/tags/stackTrace.tag)

<%@tag description="Prints stack trace of the specified Throwable"
          pageEncoding="UTF-8"%>

<%-- content (prints stack trace) --%>
<%
      java.io.PrintWriter pOut = new java.io.PrintWriter(out);
      try {
         // The Servlet spec guarantees this attribute will be available
         Throwable err = (Throwable) 
             request.getAttribute("javax.servlet.error.exception");

         if(err != null) {
            if(err instanceof ServletException) {
               // It's a ServletException: we should extract the root cause
               ServletException se = (ServletException) err;
               Throwable rootCause = se.getRootCause();
               if(rootCause == null) {
                  rootCause = se;
               }
               out.println("** Root cause is: " + rootCause.getMessage());
               rootCause.printStackTrace(pOut);
            }else {
               // It's not a ServletException, so we'll just show it
               err.printStackTrace(pOut);
            }
         }else {
            out.println("No error information available");
         }

         // Display cookies
         out.println("\nCookies:\n");
         Cookie[] cookies = request.getCookies();
         if(cookies != null) {
            for(int i = 0; i < cookies.length; i++) {
               out.println(cookies[i].getName() + "=[" + 
                   cookies[i].getValue() + "]");
            }
         }

      }catch(Exception ex) {
         ex.printStackTrace(pOut);
      }
%>

The error.jsp could be like so: (Add some humor to it, if you app somewhat casual)

<%@ page isErrorPage="true" %>
<html>
   <head>
    <title>Error</title>
   </head>
   <body>
      <div>
         <textarea class="para error">
            Aww Snap!! :( Something went wrong where it was not supposed to. 
            Must be something
            <a href="http://en.wikipedia.org/wiki/Jack_the_Ripper"&gt;Jack&lt;/a&gt; did!
            Please report this to the dev team.

            <!-- 
               <util:stackTrace />
            -->

         </p>
      </div>
   </body>
</html>

~~The "Report this Error button can submit the stack trace or mail it!~~

naikus 2010-08-24 08:45:24

having the user reporting an error is not needed in web applications.

Bozho 2010-08-24 08:52:02

@Bozho You are right! What a Klutz I am!

naikus 2010-08-24 09:30:05

Answer 3

A:

This code honestly hurts my eyes. Here is how a generic one should look like. You may find it useful.

<%@ page pageEncoding="UTF-8" %>
<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %>
<%@ taglib uri="http://java.sun.com/jsp/jstl/fmt" prefix="fmt" %>
<jsp:useBean id="date" class="java.util.Date" />
<!DOCTYPE html>
<html lang="en">
    <head>
        <title>Error</title>
        <link rel="stylesheet" href="style.css">
    </head>
    <body>
        <h1>Error</h1>
        <p>Unfortunately an unexpected error has occurred. Below you can find the error details.</p>
        <h2>Details</h2>
        <ul>
            <li>Timestamp: <fmt:formatDate value="${date}" type="both" dateStyle="long" timeStyle="long" />
            <li>Action: <c:out value="${requestScope['javax.servlet.forward.request_uri']}" />
            <li>Exception: <c:out value="${requestScope['javax.servlet.error.exception']}" />
            <li>Message: <c:out value="${requestScope['javax.servlet.error.message']}" />
            <li>Status code: <c:out value="${requestScope['javax.servlet.error.status_code']}" />
            <li>User agent: <c:out value="${header['user-agent']}" />
        </ul>
    </body>
</html>

The @page isErrorPage is by the way only useful if you want to have the ${exception} (i.e. request.getAttribute("exception") available in the JSP. In this particular case you don't need it.

And indeed, do not forward in the catch block at all. Just let it go. It will be dealt by the error page then.

} catch (MyException ex) {
    log.error(ex.getMessage(), uivex);
    throw ex; // Or throw new ServletException(ex.getMessage(), ex);
}

BalusC 2010-08-24 12:00:46

If I `throw ex` then error stack is written in server.log . I want it to only be written in `my_system.log` (comes from `log.error`)

learn_plsql 2010-08-24 13:25:02

I really don't see how that's a problem. You're already logging it to your own log using `log.error()`. If you want to disable server stderr logging, just configure so in the server config.

BalusC 2010-08-24 13:29:40

Ideally I would like to do exaclty that! so that Instead of dealing with exceptions I can just log it to my own log and then just throw it out! How would I configure/disabled stderr logging in GlassFish. I can search on google as well but not sure exactly what to look for

learn_plsql 2010-08-24 13:38:45

Again, I really don't see how that's a problem. You could just ignore the server's own logfile at its whole own. Anyway, you can configure logging in the admin console.

BalusC 2010-08-24 13:48:50

ansaurus

tags:

views:

answers:

Ideal error page for J2EE App

related questions