views:

8321

answers:

23

Suppose you're developing a software product that has periodic releases. What are the best practices with regard to branching and merging? Slicing off periodic release branches to the public (or whomever your customer is) and then continuing development on the trunk, or considering the trunk the stable version, tagging it as a release periodically, and doing your experimental work in branches. What do folks think is the trunk considered "gold" or considered a "sand box"?

+1  A: 

The trunk is generally the main development line.

Releases are branched off and often times experimental or major work is done on branches then merged back to the trunk when it's ready to be integrated with the main development line.

17 of 26
+23  A: 

I tend to take the "release branch" approach. The trunk is volatile. Once release time approaches, I'd make a release branch, which I would treat more cautiously. When that's finally done, I'd label/tag the state of the repository so I'd know the "official" released version.

I understand there are other ways to do it - this is just the way I've done it in the past.

Matt Dillard
+7  A: 

I think your second approach (e.g., tagging releases and doing experimental stuff in branches, considering the trunk stable) is the best approach.

It should be clear that branches inherit all the bugs of a system at the point in time where it is branched: if fixes are applied to a trunk, you will have to go one by one to all branches if you maintain branches as a sort of release cycle terminator. If you have already had 20 releases and you discovered a bug that goes as far back as the first one, you'll have to reapply your fix 20 times.

Branches are supposed to be the real sand boxes, although the trunk will have to play this role as well: tags will indicate whether the code is "gold" at that point in time, suitable for release.

Jon Limjap
+1  A: 

The trunk should generally be your main development source. Otherwise you will spend a lot of time merging in new features. I've seen it done the other way and it usually leads to a lot of last minute integration headaches.

We label our releases so we can quickly respond to production emergencies without distribing active development.

Jim
+4  A: 

We develop on the trunk unless the changes are too major, destabilizing, or we are nearing a major release of one of our products, in which case we create a temporary branch. We also create a permanent branch for every individual product release. I found Microsoft's document on Branching Guidance quite helpful. Eric Sink's tutorial on branching is also interesting, and points out that what works for Microsoft may be too heavy for some of the rest of us. It was in our case, we actually use the approach Eric says his team does.

Brian Stewart
+2  A: 

Attempting to manage maintenance of current production code in line with new development is problematic at best. In order to mitigate those problems code should branch into a maintenance line once testing efforts have completed and the code is ready for delivery. Additionally, the mainline should branch to assist in release stabilization, to contain experimental development efforts, or to house any development efforts whose lifecycle extends across multiple releases.

A non-maintenance branch should be created only when there is the likelihood (or certainty) of collisions among the code that would be difficult to manage any other way. If the branch does not solve a logistical problem, it will create one.

Normal release development occurs in the mainline. Developers check into and out of the mainline for normal release work. Development work for patches to current Production code should be in the branch for that release and then merged with the mainline once the patch has passed testing and is deployed. Work in non-maintenance branches should be coordinated on a case-by-case basis.

Chuck
A: 

For me, it depends on the software I'm using.

Under CVS, I would just work in "trunk" and never tag/branch, because it was really painful to do otherwise.

In SVN, I would do my "bleeding edge" stuff in trunk, but when it was time to do a server push get tagged appropriately.

I recently switching to git. Now I find that I never work in trunk. Instead I use a named "new-featurename" sandbox branch and then merge into a fixed "current-production" branch. Now that I think about it, I really should be making "release-VERSIONNUMBER" branches before merging back into "current-production" so I can go back to older stable versions...

cpm
+1  A: 

It depends on your situations. We use Perforce and have typically have several lines of development. The trunk is considered "gold" and all development happens on branches that get merged back to the mainline when they are stable enough to integrate. This allows rejection of features that don't make the cut and can provide solid incremental capability over time that independent projects/features can pick up.

There is integration cost to the merging and catching up to new features rolled into the trunk, but you're going to suffer this pain anyway. Having everyone develop on the trunk together can lead to a wild west situation, while branching allows you to scale and choose the points at which you'd like to take the bitter integration pills. We're currently scaled to over a hundred developers on a dozen projects, each with multiple releases using the same core components, and it works pretty well.

The beauty of this is that you can do this recursively: a big feature branch can be its own trunk with other branches coming off if it. Also, final releases get a new branch to give you a place to do stable maintenance.

Josh Segall
+1  A: 

If you are gonna be working through a release cycle, big feature, you get marooned to a branch. Otherwise we work in trunk, and branch for every production release at the moment we build.

Previous production builds are moved at that time to old_production_ and current prod release is always just production. All our build server knows about production is how to deploy the production branch, and we kick that build off with a force trigger.

DevelopingChris
+2  A: 

It depends on the size of your development effort. Multiple teams working in parallel won't be able to work effectively all on the same code (trunk). If you have just a small group of people working and your main concern is cutting a branch so you can continue to work while going back to the branch for making bug-fixes to the current production code that would work. This is a trivial use of branching and not too burdensome.

If you have a lots of parallel development you'll want to have branches for each of the efforts but that'll also require more discipline: Making sure your branches are tested and ready to merge back. Scheduling merges so two groups aren't trying to merge at the same time etc.

Some branches are under development for so long that you have to permit merges from the trunk to the branch in order to reduce the number of surprises when finally merging back to the trunk.

You will have to experiment if you have a large group of developers and get a feel for what works in your situation. Here is a page from Microsoft that may be somewhat useful: http://msdn.microsoft.com/en-us/library/aa730834(VS.80).aspx

Harpreet
+74  A: 

I have tried both methods with a large commercial application.

The answer to which method is better is highly dependent on your exact situation, but I will write what my overall experience has shown so far.

The better method overall (in my experience): The trunk should be always stable.

Here are some guidelines and benefits of this method:

  • Code each task (or related set of tasks) in its own branch, then you will have the flexibility of when you would like to merge these tasks and perform a release.
  • QA should be done on each branch before it is merged to the trunk.
  • By doing QA on each individual branch, you will know exactly what caused the bug easier.
  • This solution scales to any number of developers.
  • This method works since branching is an almost instant operation in SVN.
  • Tag each release that you perform.
  • You can develop features that you don't plan to release for a while and decide exactly when to merge them.
  • For all work you do, you can have the benefit of committing your code. If you work out of the trunk only, you will probably keep your code uncommitted a lot, and hence unprotected and without automatic history.

If you try to do the opposite and do all your development in the trunk you'll have the following issues:

  • Constant build problems for daily builds
  • Productivity loss when a a developer commits a problem for all other people on the project
  • Longer release cycles, because you need to finally get a stable version
  • Less stable releases

You simply will not have the flexibility that you need if you try to keep a branch stable and the trunk as the development sandbox. The reason is that you can't pick and chose from the trunk what you want to put in that stable release. It would already be all mixed in together in the trunk.

The one case in particular that I would say to do all development in the trunk, is when you are starting a new project. There may be other cases too depending on your situation.

Brian R. Bondy
Sorry, but this answer is wrong. All development should happen in the trunk. If you have something to 'spike' or some 'risky' feature, create a feature branch. Branches should be maintened for each version of the product in production, or if there is a single version use an Integration branch.
Mitch Wheat
I wasn't claiming that this was the only way, just that it's the better way. Of course if you think you have enough reasons why you think I'm wrong, then you should post it. At least my answer is justified.
Brian R. Bondy
There is only one problem with this method for DB applications. SQL migration scripts which are added to branches, merged to trunk and executed on production databases, have to be executed in creation order. What is difficult with feature branches.
Greg Dan
This is problematic, as developers can work long time on a branch that is diverging from the main trunk. Integrating that stuff later can produce large headaches. For me it was always easier to maintain a bleeding edge trunk with some minimal requirements (must always compile) and to branch of the stuff that should be stabilized for a release.
Mnementh
In response to Mnementh's post, I believe a good solution there is that a developer should periodically merge the trunk into their branch so they don't get too far away from the state of the trunk. It is up to each developer to do this often enough that they don't have a huge reintegration headache at any point in time.
RjOllos
@RjOllos: Agree or another choice is to make a new branch from trunk and merge the old branch into it. This helps keep the branches fresh, but is only needed when you take a long time to merge it to the trunk and a lot of development is done to the trunk.
Brian R. Bondy
@qntmfred: edited.
Brian R. Bondy
@Mnementh that's no excuse. Best practices and just common sense says everyone on the team should update their branches with trunk. The mainline trunk is not meant to be perfect nor is it meant to be what you push to production, it just needs to compile and that's why in good dev environments most devs are very good at making sure this happens and if it does not, the team has the right to give that person a hard time ...also tools like Cruise Control and other continuous build setups. That's what continuous integration is all about! You have QA test your branches not your mainline trunk.
CoffeeAddict
I like your answer. My follow up questions would be: (1) On average, how often do you merge branches back into the trunk and (2) how long does an average merge take? In the past, I've always done dev in the trunk, it just always seemed like merging was more of a productivity killer than the occassional broken build.
Zachary Yates
Re 1) You merge them as you are close to releasing them and for example once they are started. Re 2) Not long if you don't let your branches get too stale. Note: This dev model is not ideal for every project, and I think during initial project development it's not needed. Once you have a very big cost of introducing a bug then this model really pays off.
Brian R. Bondy
@Mitch: There's no right or wrong way of doing this.
Bryan Roth
+44  A: 

G'day,

I've worked with both techniques and I would say that developing on the trunk and branching off stable points as releases is the best way to go.

Those people above who object saying that you'll have:

  • Constant build problems for daily builds
  • Productivity loss when a a developer commits a problem for all other people on the project

have probably not used continuous integration techniques.

It's true that if you don't perform several test builds during the day, say once every hour or so, will leave themselves open to these problems which will quickly strangle the pace of development.

Doing several test builds during the day quickly folds in updates to the main code base so that other's can use it and also alerts you during the day if someone has broken the build so that they can fix it before going home.

As pointed out, only finding out about a broken build when the nightly build for running the regression tests fails is sheer folly and will quickly slow things down.

Have a read of Martin Fowler's paper on Continuous Integration. We rolled our own such system for a major project (3,000kSLOC) in about 2,000 lines of Posix sh.

HTH

cheers,

Rob

Rob Wells
What does 'continuous integration' have to do with a probability that one team is late on their feature and delays an entire release cycle? It's the best way to go 'for you'! Doing several builds per day does not solve any potential problems other than you know it builds! Your arguments don't provide proof that that is a better way (although that's the way I usually do it also).
Jeach
+2  A: 

We follow the trunk=current development stream, branch=release(s) approach. On release to the customer we branch the trunk and just keep the trunk rolling forward. You'll need to make a decision on how many releases you're prepared to support. The more you support the more merging you'll be doing on bug fixes. We try and keep our customers on no more than 2 releases behind the trunk. (Eg. Dev = 1.3, supported releases 1.2 and 1.1).

Lou
+7  A: 

A good reference on a development process that keeps trunk stable and does all work in branches is Divmod's Ultimate Quality Development System. A quick summary:

  • All work done must have a ticket associated with it
  • A new branch is created for each ticket where the work for that ticket is done
  • Changes from that branch are not merged back into the mainline trunk without being reviewed by another project member

They use SVN for this, but this could easily be done with any of the distributed version control systems.

Travis B. Hartwell
A: 

@Brian R. Bondy: Please note that this is not a solution once your team reaches a certain amount of ppl/tasks handled in parallel on the project.

Once a QA department is involved in qa, the efforts needed to provide one installation per branch in progress are simply too high. Think SOA/Clients/Servers/WebServices/Databases all of which have to be provided per branch.

This solution lacks as well the integration stage.

pointernil
We have several QA involved on our team. They test each feature from a full installer built from the branch before it is merged.
Brian R. Bondy
+5  A: 

We are using the trunk for main development and branch for releases maintenance work. It works nice. But then branches should only be used for bug fixes, no major changes, especially on database side, we have a rule that only a schema change can happen on the main trunk and never in the branch.

adriaanp
+10  A: 

Both.

The trunk is used for the majority of development. But it's expected that best efforts will be made to ensure that any check into the trunk won't break it. (partially verified by an automated build and test system)

Releases are maintained in their own directory, with only bug fixes being made on them (and then merged into trunk).

Any new feature that is going to leave the trunk in an unstable or non-working state is done in it's own separate branch and then merged into the trunk up on completion.

Andrew Edgecombe
I'm with you on this... developers that stick only to one method all the time are the problem!
Jeach
A: 

The method we use is the Perforce approach, which is discussed at length in Laura Wingerd's great book:

http://oreilly.com/catalog/9780596101855/index.html

While the book is perforce centric (Wingerd is a Perforce product manager), the concepts can be applied to any or all VCS.

The perforce approach (and platform) has served us very well. It is used at a lot of firms (google, Intuit, and, I have heard, Microsoft Windows itself).

The book is well worth the read.

A: 

There's no one-size-fits-all answer for the subversion convention question IMHO.

It really depends on the dynamics of the project and company using it. In a very fast-paced environment, when a release might happen as often as every few days, if you try to religiously tag and branch, you'll end up with an unmanageable repository. In such an environment, the branch-when-needed approach would create a much more maintainable environment.

Also - in my experience it is extremely easy, from a pure administrative standpoint, to switch between svn methodologies when you choose to.

The two approaches I've known to work best are the branch-when-needed, and the branch-each-task. These are, of course, sort of the exact opposite of one another. Like I said - it's all about the project dynamics.

Itai Raz
+1  A: 

It really depends on how well your organization/team manages versions and which SCM you use.

  • If what's next(in the next release) can be easily planned, you are better off with developing in the trunk. Managing branches takes more time and resources. But if next can't be planned easily(happens all the time in bigger organizations), you would probably end up cherry picking commits(hundreds/thousands) rather than branches(severals or tens).
  • With Git or Mercurial, managing branches is much easier than cvs and subversion. I would go for the stable trunk/topic branches methodlogy. This is what the git.git team using. read:http://www.kernel.org/pub/software/scm/git/docs/gitworkflows.html
  • With Subversion, I first applied the develop-in-the-trunk methodlogy. There was quite some work when it came to release date because everytime I had to cherry pick commits(my company is no good at planning). Now I am sort of expert in Subversion and know quite well about manaing branches in Subversion, so I am moving towards the stable trunk/topic branches methodlogy. It works much better than before. Now I am trying the way how git.git team works, although we will probably stick with Subversion.
bo
+4  A: 

I like and use the approach described by Henrik Kniberg in Version Control for Multiple Agile Teams. Henrik did a great job at explaining how to handle version control in an agile environment with multiple teams (works for single team in traditional environments too) and there is no point at paraphrasing him so I'll just post the "cheat sheet" (which is self explaining) below:

alt text alt text

I like it because:

  • It is simple: you can get it from the picture.
  • It works (and scale) well without too much merge and conflict troubles.
  • You can release "working software" at any time (in the spirit of agile).

And just in case it wasn't explicit enough: development is done in "work branch(es)", the trunk is used for DONE DONE (releasable) code. Check Version Control for Multiple Agile Teams for all the details.

Pascal Thivent
My personal experience is that this ONLY works for small teams, unlike your 'it scales' comment. As the teams grow and stories are rebased, all the other teams spend considerable amounts of team doing merges. And on very large projects (many files and KLOC), merge issues regularly start to show up, especially when there is a lot of code volatility.
Jeach
@Jeach It has worked well for us on a large project with 5 teams organized in feature teams, although I'm not denying that merging has a cost.
Pascal Thivent
A: 

Here is the SVN design that I prefer:

  • root
    • development
      • branches
        • feature1
        • feature2
        • ...
      • trunk
    • beta
      • tags
      • trunk
    • release
      • tags
      • trunk

All work is done from development/trunk, except for major features that require its own branch. After work is tested against development/trunk, we merge tested issues into beta/trunk. If necessary, code is tested against the beta server. When we are ready to roll some changes out, we just merge appropriate revisions into release/trunk and deploy.

Tags can be made in the beta branch or the release branch so we can keep track of specific release for both beta and release.

This design allows for a lot of flexibility. It also makes it easy for us to leave revisions in beta/trunk while merging others to release/trunk if some revisions did not pass tests in beta.

Kevin Crowell