ansaurus

Question

More Eyeballs on my Poor mod_rewrite Attempt Please

Answer 1

A:

This should do it:

RewriteRule ^\/includes\/gp\.php5?\?p=([a-f,0-9]{64})$ /legacy/gp.php?p=$1

Robin 2010-09-03 03:54:55

Hmm, I tried it but unfortunately it doesn't work.. legacy urls can be either `php` or `php5`, and the file may not be in the `includes` dir... Should have said that in the question sorry.

Michael Robinson 2010-09-03 04:01:15

`RewriteRule ^\/(includes\/)?gp\.php5?\?p=([a-f,0-9]{64})$ /legacy/gp.php?p=$2`That makes the includes/ dir optional and the question mark after the 5 in php5 makes that character optional. Use the rewrite alone without and [] modifiers. It should work (I have no place to really test it)

Robin 2010-09-04 10:40:24

Answer 2

+2 A:

The input to the RewriteRule test pattern will not contain the query string, so testing for it will prevent the rule from ever matching and applying.

Taking that into account, we can rework the rule into something like this:

RewriteRule ^(includes/)?gp2?\.php5?$ /legacy/gp.php5 [NC,L]

Assuming that the query string will already be in the format you want, we can just let mod_rewrite append it automatically by not specifying a replacement in our rewrite.

If you aren't sure that the query string will always be just p=HASH, and want to guarantee that it will be for the target script, we can extend the rule block to take that into account, looking for the p parameter in the query string and replacing the existing query string with just that piece:

RewriteCond %{QUERY_STRING} (^|&)(p=[^&]+)(&|$) [NC]
RewriteRule ^(includes/)?gp2?\.php5?$ /legacy/gp.php5?%2 [NC,L]

Per Roland Illig's comment, you could also do the following to be less restrictive on the directory the file is in:

RewriteCond %{REQUEST_URI} !^/legacy/
# Input to RewriteRule in .htaccess never has a leading slash, so make sure
# we're at the beginning or there was a slash before the filename
RewriteRule (^|/)gp2?\.php5?$ /legacy/gp.php5 [NC,L]

Edit: Changed rules to reflect how they would be defined in httpd.conf instead of .htaccess.
Edit: ...And then changed it back again.

Tim Stone 2010-09-03 06:14:43

I suggest `RewriteRule /gp2?\.php5?$ /legacy/gp.php?%2 [NC,L]` instead. It's shorter, doesn't need a specific directory and makes sure that the `php5?` comes at the very end of the URI.

Roland Illig 2010-09-03 07:25:23

@Roland Illig - Whoops, I had forgotten the end anchor. I also removed the unnecessary character classes. If we just anchor at the end though, we need an additional `RewriteCond` to [prevent an internal redirect loop](http://stackoverflow.com/questions/3482106/rewrite-problem-last-not-being-respected/3482267#3482267) since the test pattern matches what we rewrite to. That might not be a bad idea depending on the scenario though, so I'll add that in as another option.

Tim Stone 2010-09-03 07:39:36

Thanks Tim, I tried them all, but this http://www.ecpod.com/includes/gp.php?p=eb95f287d3647971045ab284adce523016feb95f287d364797e035baabad68f8 still gives 404.

Michael Robinson 2010-09-03 08:30:08

@Michael Robinson - When I click the link, I see an image that says "ECPod Share Your World", so did you get it to work just now?

Tim Stone 2010-09-03 08:33:05

Oops, I just see that I got it wrong. The documentation clearly says that *The Substitution of a rewrite rule is the string that replaces the original URL-path that was matched by Pattern.* So you should try `RewriteRule (?:^|.*/)gp2?\.php5?$ /legacy/gp.php [NC,L]`. I don't know if that works in a `.htaccess` file though.

Roland Illig 2010-09-03 15:46:11

That results in a 500 error :(

Michael Robinson 2010-09-03 22:56:54

@Tim I think that is because you're clicking the link from SO, so you don't have the correct referral header. There is hotlinking protection on those urls that works ok... If you refresh that page a few times you'll see it not working

Michael Robinson 2010-09-03 22:57:39

This is all happening in a `httpd.conf` file, not `.htaccess`

Michael Robinson 2010-09-03 22:59:07

@Michael Robinson - Ah, I see, I do get the 404 now. So you're defining the rules in `httpd.conf`? (I had assumed `.htaccess` based on your question tags) I've updated the rules accordingly.

Tim Stone 2010-09-03 23:10:21

Hmm, I tried them all but still get the 404 page... If it's rewriting properly one should see a blank page, as `/legacy/gp.php5` echo's a blank string.

Michael Robinson 2010-09-06 00:40:16

@Michael Robinson - I assume you noticed, but I had it rewriting to `gp.php` instead of `gp.php5`. I fixed the answer to reflect that change. As you have access to `httpd.conf`, can you make a [`RewriteLog`](http://httpd.apache.org/docs/current/mod/mod_rewrite.html#rewritelog) with `RewriteLogLevel` set to 9? Hopefully then we could figure out what's going on to mess this up.

Tim Stone 2010-09-06 01:32:02

Appended output to my question

Michael Robinson 2010-09-06 02:47:07

@Michael Robinson - Thanks! Do you have these rules in a `<Directory>` section inside of `httpd.conf` or something? `mod_rewrite` is operating in a per-directory context, but it shouldn't be.

Tim Stone 2010-09-06 02:54:16

Yeah I do, are they allowed in there?

Michael Robinson 2010-09-06 03:04:46

@Michael Robinson - They're allowed, but it's better (if you have access to `httpd.conf` like you do) to define them directly in the server/virtual server configuration. If you'd rather not do that, I need to revert the rules a bit, because defining them in `<Directory>` is the same as defining them in `.htaccess`.

Tim Stone 2010-09-06 03:15:51

I've tried the rules inside / outside of `<Directory>`, still no joy :(

Michael Robinson 2010-09-06 06:09:57

@Michael Robinson - The `RewriteLog` should look a bit different when they're outside of `<Directory>`, would you mind posting anything new?

Tim Stone 2010-09-06 06:26:07

Updated, still doesn't work :(

Michael Robinson 2010-09-06 11:50:36

@Michael Robinson - Hmm...This may sound like a stupid question, but did you make sure to put a `RewriteEngine On` with the rules you put outside of the `<Directory>`? It sounds like there's one still inside the `<Directory>`, but maybe not one outside it. My log shows (for rules outside) `(2) init rewrite engine with requested uri /includes/gp2.php5` ... `(2) local path result: /legacy/gp.php5` (so it works fine on my server), but yours only seems to have the per-directory line still.

Tim Stone 2010-09-06 17:14:58

Yah just checked, it's on outside the directory

Michael Robinson 2010-09-06 22:12:58

@Michael Robinson - That's...really odd. Alright. I've changed the rules back. Put these rules into the `<Directory>` section where you had them, then please post any changes to the `RewriteLog`, and hopefully we'll finally get something that works in your environment.

Tim Stone 2010-09-07 05:43:11

ansaurus

tags:

views:

answers:

More Eyeballs on my Poor mod_rewrite Attempt Please

related questions