views:

123

answers:

2

I have an int pointer (int *count) if i want to increment the integer being pointed at using ++ I thought I would call

*count++;

However, I am getting a build warning "expression result unused". I can call

*count += 1;

But, I would like to know how to use the ++. Any ideas?

+5  A: 

Try using (*count)++. *count++ might be incrementing the pointer to next position and then using indirection (which is unintentional).

Sidharth Panwar
+12  A: 

The ++ has equal precedence with the * and the associativity is right-to-left. See here. It's made even more complex because even though the ++ will be associated with the pointer the increment is applied after the statement's evaluation.

The order things happen is:

  1. Post increment, remember the post-incremented pointer address value as a temporary
  2. Dereference non-incremented pointer address
  3. Apply the incremented pointer address to count, count now points to the next possible memory address for an entity of its type.

You get the warning because you never actually use the dereferenced value at step 2. Like @Sidarth says, you'll need parenthesis to force the order of evaluation:

 (*ptr)++
Doug T.
I'd add that I always write this case as `++*ptr;` because the precedence is unambiguous, and if the result isn't used there is no need to distinguish between preincrement and postincrement.
RBerteig
@RBerteig: It may be unambiguous to the compiler but it is still confusing to a human. Much better to use parenthesis as this will make it easier to read.
Martin York
@Martin, over use of parenthesis can be just as confusing to a human. When written as I did, there is only one plausible order of operations, and matches the natural reading of "increment", "something pointed to by", "p".
RBerteig
@RBerteig: If you are claiming that `++*ptr` is easier to read than `++(*ptr)` then I hope you get slapped down in your next code review.
Martin York
I do so claim, and have for ~25 years. No slaps yet.
RBerteig
I did slap someone recently for writing `!(!(foo))`. There *is* such a thing as too many parentheses.
RBerteig
@RBerteig: Half a century of Lisp disagrees with you. ;)
Deniz Dogan