ansaurus

Question

Javascript Arrays - Consolidating Multiple Arrays Help

Answer 1

+1 A:

Code generation with JSP is a baaad idea... And this is definatly the worst code generation I've ever seen. That said... lets see if we can fix your mess...

First, all those functions are meaningless, your outputting data in your jsp indiscriminatly, the functions actually only slow down performance. So we better just render the array (mainResults) you want right away.

<% if(products != null) { %>

   var mainResults = [
      <% for (int i=0; i<products.productsList.size(); i++) {
         Product currProd = products.productsList.get(i);
      %>

         {
            count : "<%= i %>",
            id : "<%= prodId %>",
            name : "<%= prodName %>",
            manufacturer : "<%= prodManufacturer %>",
            description : "<%= prodDescription %>",
            numretailer : "<%= prodRetailer %>",
            logo : "<%= prodLogo %>",
            logoh : "<%= prodLogoHeight %>",
            logow : "<%= prodLogoWidth %>",
            lowpriceamt : "<%= lowPriceAmount %>",
            lowpricecur : "<%= lowPriceCurrency %>",
            highpriceamt : "<%= highPriceAmount %>",
            highpricecur : "<%= highPriceCurrency %>",
            ratings : [
               <% for(int j=0; j<currProd.ratingList.size(); j++) { %>
                  {
                     count : "<%= j %>",
                     type : "<%= prodRatType %>",
                     average : "<%= prodRatAvg %>",
                     number : "<%= prodRatNum %>"
                  }
               <% if(j < (currProd.ratingList.size() - 1)) { %>
               ,
               <% } %>

               <% } %>
            ],
            retailers : [
               <% for(int x=0; x<currProd.retailerList.size(); x++) { %>
                  {
                     retailers.count : "<%= x %>",
                     id : "<%= currProd.retailerList.get(k).id %>",
                     name : "<%= currProd.retailerList.get(k).name %>",
                     purchaselink : "<%= currProd.retailerList.get(k).link %>",
                     logo : "<%= retailLogo %>",
                     leadtime : "<%= currProd.retailerList.get(k).leadTime %>",
                     stock : "<%= currProd.retailerList.get(k).stockInfo %>",
                     priceamt : "<%= currProd.retailerList.get(k).price.amount %>",
                     pricecur : "<%= currProd.retailerList.get(k).price.currency %>",
                     sourcetype : "<%= currProd.retailerList.get(k).sourceType %>",
                     sourcedate : "<%= currProd.retailerList.get(k).sourceDate %>",
                     shipminprice : "<%= minShipPrice %>",
                     shipmincur : "<%= minShipCurrency%>",
                     shipmaxprice : "<%= maxShipPrice %>",
                     shipmaxcur : "<%= maxShipCurrency %>"
                  }

                  <% if(x < (currProd.retailerList.size() - 1)) { %>
                  ,
                  <% } %>

               <% } %>
            ]
         }

         <% if(i < (products.productsList.size() - 1)) { %>
         ,
         <% } %>

      <% } %>
   ];

<% } %>

I might've made some typos, this was a lot of work to fix... But this is a marginally better setup.

But for the love of god, look up how to create JSON with Java and create your model in Java and then parse to JSON.

BGerrissen 2010-09-16 13:59:41

Obviously... this is a pain to maintain, again, investigate and master proper use of JSON parsers in Java.

BGerrissen 2010-09-16 14:01:57

Kudos for the effort :) As to converting a Java object to JSON, I'd suggest using [Google Gson](http://code.google.com/p/google-gson/). It's then as simple as `String json = new Gson().toJson(products);`.

BalusC 2010-09-16 14:02:30

Thank you so so much!! Your solution works a treat and I am really grateful to you for spending your time looking at this for me :)

jimpose 2010-09-16 16:46:08

I will have a serious talk with the lead developer about the use of a JSON parser but in the meantime thank you so much again for your sterling work on this for me - it is greatly aprreciated and I can finally get a good nights sleep this evening!

jimpose 2010-09-16 16:48:40

In addition to thanking BGerrissen for the above solution, thank you to those who also provided their feedback on this one - what a great forum this is :)

jimpose 2010-09-16 16:53:57

ansaurus

tags:

views:

answers:

Javascript Arrays - Consolidating Multiple Arrays Help

related questions