views:

91

answers:

2

Quoting from Perl::Critic::Policy::InputOutput::ProhibitExplicitStdin

Perl has a useful magic filehandle called *ARGV that checks the command line and if there are any arguments, opens and reads those as files. If there are no arguments, *ARGV behaves like *STDIN instead. This behavior is almost always what you want if you want to create a program that reads from STDIN. This is often written in one of the following two equivalent forms:

while (<ARGV>) {
  # ... do something with each input line ...
}
# or, equivalently:
while (<>) {
  # ... do something with each input line ...
}
  • Is it "just a convention" or are there some solid reasons not to use <STDIN> ?

I feel <STDIN> makes my code's intentions more clear than using <> or <ARGV>.

The flow of my code is like this

my @inp = <STDIN>;
my $len = $inp[0];

...

for(my $i = 0; $i < ($len + 0); $i++) {
    my @temp = split (' ', $inp[$i]);
    ...
}
+4  A: 

It's because using <ARGV> will enable users to either specify files to read from as arguments, or pipe stuff into stdin while specifying no arguments. If you use <STDIN>, only piping will work.

Of course it's up to you to decide if you think people would like to be able to specify files as command line arguments, but it's something a lot of programs support so it might be worth thinking about.

Matti Virkkunen
Thanks. If this is the only reason then I feel `<STDIN>` is better.
Lazer
@Lazer: it's not "better", it's imposing restrictions upon the ways you can use the program. Why do that unnecessarily?
Ether
Perl::Critic is based on the book "Perl Best Practices", which simply states: "Avoid using *STDIN, unless you really mean it." Justification given is a longer version of the above answer. If you really mean that only STDIN will do, no command line arguments accepted - then use explicit STDIN.
jmanning2k
+4  A: 

You use the one that does what you want to do. See perlvar for an explanation of the ARGV filehandle. ARGV also reads from filenames you specify on the command line. Maybe you want that feature, maybe you don't.

And, you don't have to do what Perl::Critic says. Many of those policies are the opinions of a small group of people. If you only want to read from STDIN explicitly, that's what you need to do. The people writing the Critic policies aren't there to state what you need to do. Asking any question like this is mostly pointless without the context of its application. General rules are merely general, and break down when talking about specific cases.

I'm not sure why you think your intent is clearer with STDIN because you didn't tell us your intent. Code almost never speaks for itself because we tend to code the solution instead of stating the problem. The solution might not be the right one.

In your case, I think this code is more clear because it's written in Perl instead of the C dialect you're using :)

 chomp( my $length = <STDIN> );

 my $count = 0;
 while ( <STDIN> ) {
     last if $count++ > $lines_to_read; 

     my @temp = split ' ';
     ...;
     }
brian d foy