ansaurus

Question

Answer 1

+1 A:

~~It looks like you're closing your database query within the loop~~

I'd recommend to read your data into arrays and loop over those rather than mixing data access and rendering logic.

edit

How about

<div id="slider">
    <div class="scroll" >
        <div class="scrollContainer">
<%
    Set oRS = Server.CreateObject("ADODB.Recordset")

    oRS.Open "Select ph.*, pic.picture FROM prop_home ph INNER JOIN pictures pic ON ph.propid = pictures.propid where ph.packageid='2'", xDb_Conn_Str, 3, 3

    If Not oRS.eof Then
%>
        <div class="listings">
            <ul class="clear" id="navigation-feature">

<%
         Do While Not oRS.eof
             counter = counter + 1
%>
                <li class="list1" id="feature-tab<%=counter%>">
                    <a href="#">
                        <img src="admin/uploads/<%=oRS("picture")%>" style="height:auto !important;max-height:104px;max-width:170px;width:auto !important;"/>
                        <label>
                            <%=oRS("name")%>From €<%=oRS("pricemin")%>
                        </label>
                    </a>
                 </li>
<%
             oRS.MoveNext
         Loop

         oRS.Close
%>
             </ul>
         </div>

<%

     End If
%>
     </div>
  </div>

I may err here too but you're closing one more <div/> than you open and you should enclose the (and surrounding <div/>) inside theIf block.

Filburt 2010-09-21 13:15:43

picrs2.close should be inside the loop or else you get the error that recordset is open (ADODB.Recordset error '800a0e79'Operation is not allowed when the object is open. )don't think so? and about the getrow() yes will use that in the final production server for the moment i play like this .. but you didn't answer to my question

Teodor 2010-09-21 13:23:52

@Teodor: Right, I mixed up picrs2 and ors2 there. How about querying everything in one query?

Filburt 2010-09-21 13:34:27

@Teodor: see my updated answer - the magic number 4 is still a little unclear.

Filburt 2010-09-21 13:57:51

Filburt one properties had more than one pic so your inner join won't work

Teodor 2010-09-21 14:08:07

forgot to tell you that prop_home is a view so i managed to fix the innerjoin problem using a subquery inside the inner join

Teodor 2010-09-21 17:40:00

Answer 2

+2 A:

You need to ask the counter if mod 4 is 0 and change the listing number. Or a simple way is to add a second counter, and reset it every 4 cycles

Like this (Simplified code):

<div id="slider">
  <div class="scroll" >
    <div class="scrollContainer">
      <%Set oRS2 = Server.CreateObject("ADODB.Recordset")
      oRS2.Open "..."
      Set picRS2 = Server.CreateObject("ADODB.Recordset")
      dim FeatureCounter 
      FeatureCounter = 1
      if not ors2.eof then
         do while not ors2.eof
         counter=counter+1

         If featureCounter = 1 then
            %>
            <div class="listings">
               <ul class="clear" id="navigation-feature<%= trim(featureCounter)%>">
            <%
          end if
          ''// not good to open a new recordset for every record, 
          ''// but leave it here because is not the scope of the answer
          picRS2.Open "..."
          ''// you should also check if picRS2 not EOF
           %>
             <li class="list1" id="feature-tab<%=counter%>">
                <a href="#"><img src="..."></a>
             </li>
           <%
           picrs2.close


           If FeatureCounter = 4 then
              FeatureCounter = 1 ''//reset the counter
              %>
                </ul>
                </div>
              <%
           else
              FeatureCounter = FeatureCounter + 1
           end if


           ors2.movenext
           loop

           end if%>

        </div>
    </div>
</div>

Eduardo Molteni 2010-09-21 13:39:40

very close thank you but unfortunatelly won't work , look at : http://tourscript.com/gabriele2/default3.asp is your example it generate all the time <div class="listings"> <ul class="clear" id="navigation-feature1">and it should be just one time then 4 of li and then <div class="listings"> <ul class="clear" id="navigation-feature2">

Teodor 2010-09-21 14:26:22

Are you sure you added `FeatureCounter = FeatureCounter + 1` line at bottom?

Eduardo Molteni 2010-09-21 15:13:51

yes exactly as in your example

Teodor 2010-09-21 15:42:35

feature counter is always 1 it should become 2 after 4 records never get to 4

Teodor 2010-09-21 15:46:27

however the problem are: id="navigation-feature" first is not 1 and second is id="navigation-feature2" if you look in my initial HTML and second every li should have an alternating class list1 and list2

Teodor 2010-09-21 16:13:02

Teodor: Yes, I guess I missed a few details, but surely you got them right.

Eduardo Molteni 2010-09-21 18:38:58

thank you Eduardo

Teodor 2010-09-22 11:12:13

Answer 3

A:

Made it ...

  <div id="slider">
            <div class="scroll">
                <div class="scrollContainer">
                     <%Set oRS2 = Server.CreateObject("ADODB.Recordset")

                        oRS2.Open "Select * FROM prop_home where packageid='2'",xDb_Conn_Str,3,3
                        Set picRS2 = Server.CreateObject("ADODB.Recordset")
                        if not ors2.eof then
                        dim FeatureCounter 
                          FeatureCounter = 1
                        othercounter=1 
                         do while not ors2.eof

                          counter=counter+1
                        if   featureCounter =1 then

        %>
                <div class="listings">
                         <ul class="clear" id="navigation-feature<%if othercounter <> 1 then  response.Write(othercounter) end if%>">
                   <%end if%>



                <%
     picRS2.Open "Select picture FROM pictures where propid='"&ors2("propid")&"'",xDb_Conn_Str

                If counter MOD 2 = 0 Then
                cl=2
                else 
                cl=1
                end if

                %>
                            <li class="list<%=cl%>" id="feature-tab<%=counter%>">
                                <a href="#"><img src="admin/uploads/<%=picrs2("picture")%>" alt="" title="" style="height:auto !important;max-height:104px;max-width:170px;width:auto !important;"/><label><%=ors2("name")%>From €<%=ors2("pricemin")%></label></a>
                            </li>
                           <% picrs2.close


       If FeatureCounter mod 4 = 0 then
         FeatureCounter = 1 ''//reset the counter

         othercounter = othercounter+1

 %>
                        </ul>
                    </div>
                    <%
        else
          FeatureCounter = FeatureCounter + 1
       end if


       ors2.movenext
       loop

       end if%>   </ul>
       </div>
                </div>
            </div>
        </div>
    </div>

Teodor 2010-09-21 16:49:33

ansaurus

tags:

views:

answers:

classic ASP recordset problem

related questions