ansaurus

Question

Answer 1

A:

$_POST[txtcompname] and all the other variables should be quoted. Try with $_POST['txtcompname']. Also, do var_dump($_POST) and check if you have all the values that you are reffering to.

vucetica 2010-09-22 10:17:25

Quotes has nothing to do with empty submit.

fabrik 2010-09-22 10:19:03

Answer 2

+1 A:

i found a few mistakes in your code just by regarding it... make sure you have all warning on so you could see them

1) Brackets after the if, or else only the assignation of the $des variable will be executed when the form is submitted

2) $_POST is an array.. you need the quotes $_POST['txtcompname']

finally make sure that the submit input has name="submit" ,although i think it's better to evaluate the submit by using if !empty($_POST)

good luck

pleasedontbelong 2010-09-22 10:20:47

Answer 3

+4 A:

There are several potential problems here, but I'd need to see your whole script to give you a definitive answer.

Questions you should be asking - is $_POST['submit'] set? Print something to output inside the if to find out. Is your submit button value "Submit" rather than "submit" for example.

You should also try looking at mysql_error() to see if the DB is rejecting your query. Are your field names correct for example?

Lastly, $_POST[txtcompname] should be $_POST['txtcompname'] and your other $_POST vars also need quotes round the form field names. Depending on your version and configuration of PHP you might get away with this, but it's bad practice. Without the quotes PHP interprets txtcompname as a constant (as defined by define()). By default that may be set to the string txtcompname, so it might work, but you shouldn't rely on it.

Also, if this is a public facing site, you're setting yourself up for SQL injection problems since you've not escaped or otherwise sanitised your input. If your input has ' characters in it your query will break.

Peter Bagnall 2010-09-22 10:21:47

Answer 4

+1 A:

Check if Form got submitted
Debug the submitted Data (print)
Validate // Sanitize the Data
Build the Query Debug it (print)
Push the Query to the Database
Print error (if there is one)

If done so you have had seen that there is missing a space between enquiry and (Companyname

function debug($var, $label = '') {
    echo $label
        . '<pre>'
        . print_r($var, true)
        . '</pre>';
}

if (array_key_exists('submit', $_POST)) {
    debug($_POST, '_POST');
    $_dbCompany = mysql_real_escape_string($_POST['txtcompname']);
    $_dbName        = mysql_real_escape_string($_POST['txtname']);
    $_dbPhone       = mysql_real_escape_string($_POST['txtphno']);
    $_dbEmail       = mysql_real_escape_string($_POST['txtemail']);
    $_dbAdress      = mysql_real_escape_string($_POST['txtaddress']);
    $_dbComments    = mysql_real_escape_string($_POST['txtcomments']);

    $_prepareSQL = "INSERT INTO 
        enquiry (Companyname,Name,Phno,Email,Address,Comments) 
        VALUES ('%s', '%s', '%s', '%s', '%s', '%s')";
    $statement = sprintf($_prepareSQL, $_dbCompany, $_dbName, $_dbPhone, $_dbEmail, $_dbAdress, $_dbComments);
    debug($statement, 'SQL-Query');

    $result = mysql_query($statement) || trigger_error(mysql_error(), E_USER_ERROR);
}

maggie 2010-09-22 10:48:37

ansaurus

tags:

views:

answers:

Why doesn't my form get posted in PHP?

related questions