ansaurus

Question

Simple Handmade PHP Template Engine not working! Help Please

Answer 1

+2 A:

your syntax is weird, try this

  abstract class MyTemplate {

  protected $arrayOfSpaces;
  protected $arrayOfVariables;
  protected $output;

  public abstract function __construct(); 

  function outputHTML(){
    echo $this->output;
  }
}
  class MyTemplateMain extends MyTemplate {
    public function __construct(){
     $this->output="<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"
             \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\"&gt;
             <html>
             <head>
             </head>
             <body>
             I love Rock n Roll!!!
             </body>
             </html>";
    }

  }

$page=new MyTemplateMain();
$page->outputHTML();

Hannes 2010-09-27 08:48:35

Hmm you mean everything in one file? That shouldn't be the source of the problem, but Ok. Done that. STill doesn't work.. I'm thinking I must have overlooked some tiny detail..Thx anyway

Felipe Almeida 2010-09-27 08:52:39

no sorry :) you got me wrong, the file wasn't the Problem (but i did it in one to save time). First i don't know any OOP Angle PHP5 (or 5.3) has, but i mainly changed the way you access the variables ($this->output insteadt of just $output or this.$output ) and changed the __constructur to public

Hannes 2010-09-27 09:25:57

I think I solved it. I guess you must name the function ABSTRACT PROTECTED rather than PROTECTED ABSTRACT. Apparently, the "abstact" keyword comes first

Felipe Almeida 2010-09-27 09:37:41

thats better coding style, but for the parser (as far as i know and tested it under pgp 5.3) it doesn't make a difference

Hannes 2010-09-27 09:45:18

Answer 2

A:

try $base->output instead of $this->output.

elsni 2010-09-27 08:53:46

Answer 3

A:

Ok. I don't know why but now it's working. I rewrote it some times so I must've done some correctly even though unintended. Here is the code if anyone wants to have alook and compare the versions. Thanks all

abstract class MyTemplate {

protected $arrayOfSpaces;
protected $arrayOfVariables;
protected $output;


function outputHTML(){
    echo $this->output;
}

}

class MyTemplateMain extends MyTemplate {

function __construct(){
    $this->output="<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"
             \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\"&gt;
             <html>
             <head>
             </head>
             <body>
             I love Rock n Roll!!!
             </body>
             </html>";
}
}

Felipe Almeida 2010-09-27 09:27:31

if first example in `outputHTML` function you have `echo $output;` which echo undefined variable and in second you have `echo $this->output;` which output object field.

jcubic 2010-09-27 10:20:16

the problem is not the order of abstract and protected, its the handling of variables in class context

Hannes 2010-09-27 10:44:34

Answer 4

+2 A:

change :

 function outputHTML(){
    echo $output;
  }

to :

 function outputHTML(){
    echo $this->output;
  }

ts 2010-09-27 12:21:34

Hm... PHP can't guess which variable I'm talking about if i don't use $this? Or is this just stylewise?

Felipe Almeida 2010-09-27 12:28:55

PHP doesn't even try to guess. `$this` is always required.

Vegard Larsen 2010-09-27 12:32:54

php doesn't ... guess

Hannes 2010-09-27 12:49:37

in the context of object, $this always referes to, well... that object. But you can only access it from the inside of the object.

ts 2010-09-27 15:09:07

ansaurus

tags:

views:

answers:

Simple Handmade PHP Template Engine not working! Help Please

related questions