Android boolean preference problem

Question

I want to have the status of a checkbox be saved into my prefs.

I set a listener on the checkbox, and if it is checked I do a prefs.putBoolean("cbstatus", true), and it is it unchecked i do a prefs.putBoolean("cbstatus", false);

Trouble is, in my onStart() when I get prefs, my Boolean getcbstatus = prefs.getBoolean("cbstatus", false); will always return a true, regardless of how my listener should have set that status previously.

What am I doing wrong? I have working prefs for other things like spinners, textviews, and edit texts, but what should be the simplest type (a boolean) is giving me a hard time.

I've even tried taking out all code related to listeners and pref setting for this checkbox, so that the only code in the entire activity that deals with the checkbox is in the line

Boolean getcbstat = prefs.getBoolean("cbon", false);
    if (getcbstat = true) {
        cb1.setChecked(true);
    }
    else {
        cb1.setChecked(false);
        format.setVisibility(View.VISIBLE);
    }

Since there is no cbon preference (i deleted them all), it should return false by default and the box should be unchecked since. cb1, of course, is the name of my checkbox.

Any ideas?

Update on the code:

OnClickListener cb = new OnClickListener() {
    public void onClick(View v) {
        if (cb1.isChecked()) {
            prefs.putBoolean("cbon", true);
        }
        else {
            prefs.putBoolean("cbon", false);
        }
    }
};

And in the onStart():

        Boolean getcbstat = prefs.getBoolean("cbon", false);
        cb1.setChecked(getcbstat);

Answer 1

You've accidentally assigned it to true in your if statement.

Change it to this

if (getcbstat == true)

[Edit -- How to use shared preferences (instead of Java's preferences class)] How to use SharedPreferences:

private SharedPreferences mPref;
@Override
public void onCreate(Bundle bundle) {
super.onCreate(bundle);

mPref = getSharedPreferences("my_prefs_file", MODE_PRIVATE);

//Other onCreate code goes here...

}  

//Example of where you might want to save preferences
@Override
protected void onPause() {
super.onPause();
Editor prefEdit = pref.edit();

prefEdit.putBoolean("cbon", true);
prefEdit.commit();

}

When you need to read it later:

//Example of where you might want to save preferences
@Override
protected void onResume() {
super.onResume();
boolean getcbstat = pref.getBoolean("cbon", false);
}

It would probably be a good idea to make the pref variable class level and get the preferences object in the onCreate section. Change "my_prefs_file" to whatever you like, but remember that that string is what you will use to access that that particular set of preferences from within your application. I also recommend using constants instead of raw strings for the access keys (like "cbon").

Good luck:)

Answer 2

rebooted the emulator, got a whole bunch of new errors when I ran the app fresh.

10-06 05:18:34.045: ERROR/AndroidRuntime(223): Uncaught handler: thread main exiting due to uncaught exception
    10-06 05:18:34.115: ERROR/AndroidRuntime(223): java.lang.RuntimeException: Unable to instantiate activity ComponentInfo{com.sean.sean/com.sean.sean.dofcalc2}: java.lang.NullPointerException
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2402)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2497)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.app.ActivityThread.access$2200(ActivityThread.java:119)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1848)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.os.Handler.dispatchMessage(Handler.java:99)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.os.Looper.loop(Looper.java:123)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.app.ActivityThread.main(ActivityThread.java:4338)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at java.lang.reflect.Method.invokeNative(Native Method)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at java.lang.reflect.Method.invoke(Method.java:521)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:860)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at dalvik.system.NativeStart.main(Native Method)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223): Caused by: java.lang.NullPointerException
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:146)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at com.sean.sean.dofcalc2.<init>(dofcalc2.java:47)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at java.lang.Class.newInstanceImpl(Native Method)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at java.lang.Class.newInstance(Class.java:1479)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.app.Instrumentation.newActivity(Instrumentation.java:1021)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2394)
    10-06 05:18:34.115: ERROR/AndroidRuntime(223):     ... 11 more
    10-06 05:18:34.135: INFO/Process(50): Sending signal. PID: 223 SIG: 3
    10-06 05:18:34.135: INFO/dalvikvm(223): threadid=7: reacting to signal 3
    10-06 05:18:34.145: ERROR/dalvikvm(223): Unable to open stack trace file '/data/anr/traces.txt': Permission denied