If grep fails delete the file

Question

Heya guys, I have this small script and i need to grep all the files and leave only the ones that contain a keyword and I'm stuck on this, any help in pointing out my dumb errors is appreciated :)

#!/bin/bash

server=(server1...server24)

.
.
.

for ((n=0; n <= 24 ; n++))
do
        if grep -q "KEYWORD" directory/${server[$n]}.html ; then
                echo Empty
        else
                rm -f directory/${server[$n]}.html
        fi
done

.
.
.

Answer 1

you can use -l option for grep

grep -l "KEYWORD" directory/server*html | while read -r FOUND
do
   rm -f .....
   do some other processing here.....
done

Answer 2

Ensure the following:

• Separate the server names in the array by whitespace as:

  server=(server1 server2 server3 ... server24)

• The valid indices are from 0 to 23 (one less than the number of array elements).
  So your for loop should be:

  for ((n=0; n <= 23 ; n++)) or for ((n=0; n < 24 ; n++))

Answer 3

I would suggest you do the grep for each file and then test the exit status $? - and fix your brace expansion.

so...

 for ((n=0; n <= 24 ; n++))
    do
      grep -q "KEYWORD" directory/server${n}.html
      if [ $? -eq 0 ] then
          echo "directory/server${n}.html - Has keyword"
      else
          rm -f directory/server${n}.html
      fi
    done

Answer 4

#!/usr/bin/env bash

server=(server{1..24})

for((n=0; n<24; n++))
do
    if grep -q 'keyword' ${server[$n]}; then
        echo Empty
    else
        rm -f ${server[$n]}
    fi
done

Answer 5

You don't have to make sure your count matches if you let your code do it for you in one of the following ways:

servers=(foo bar baz)
for server in ${servers[@]}
do
    if ! grep -qs "KEYWORD" directory/$server.html 
    then
        rm ...

or

servers=(foo bar baz)
for ((n = 0; n < ${#servers[@]}; n++))
do
    if ! grep -qs "KEYWORD" directory/${servers[$n]}.html 
    then
        rm ...

Use ! to invert the condition so that it's "if the file does NOT contain the keyword, then delete it".

Use the grep option -q to quiet the output and -s to suppress error messages.