views:

59

answers:

2

Hi,

I am trying to do a simple test in Python using unittest, to see if a class throws an exception if it gets an unsuitable input for the constructor. The class looks like this:

class SummaryFormula:
    def __init__( self, summaryFormula):
        self.atoms = {}
        for atom in re.finditer( "([A-Z][a-z]{0,2})(\d*)", summaryFormula):
            symbol = atom.group(1)
            count = atom.group(2)

            if pocet != "":
                self.atoms[ symbol] = int(count)
            else:
                self.atoms[ symbol] = 1

My test is following:

    class ConstructorTestCase(unittest.TestCase):
      def testEmptyString(self):
        self.assertRaises(TypeError, ukol1.SummaryFormula(), "testtest")

    if __name__ == '__main__':
      unittest.main()

All I want is the test to fail, meaning that the exception of unsuitable input for constructor is not handled.

Instead, I get an error: __init__() takes exactly 2 arguments (1 given).

What am I missing? What is the second argument I should specify?

Also, what type of Error should I use to handle exception that an input not matchable by my regexp was passed to the constructor?

Thank you, Tomas

+2  A: 

Thats because your class requires a parameter while instantiating the object

while you are passing

ukol1.SummaryFormula()

you should have been passing the parameter summaryFormula to it.

ukol1.SummaryFormula(someSummaryFormula)

Also the confusion is because your class name is SummaryFormula and the parameter that you pass to __init__ is also SummaryFormula

or should this be

self.assertRaises(TypeError, ukol1.SummaryFormula, "testtest")
pyfunc
This was of course the first thing that I tried, but if I use self.assertRaises(TypeError, ukol1.SummaryFormula("testtest"), "testtest"), I get other error: SummaryFormula instance gas no __call__ method. And isn't it that you specify the arguments passed to the function tested in assertRaises as a third (or fourth, fifth, ...) argument of the assertRaises() function?
Tomas Novotny
@Tomas Novotny : I did add the second change while I was trying to run your code. Repeating it here : self.assertRaises(TypeError, ukol1.SummaryFormula, "testtest")
pyfunc
+7  A: 

assertRaises is a little confusing, because you need to give it the callable, not an expression that makes the call.

Change your code to:

self.assertRaises(TypeError, ukol1.SummaryFormula, "testtest")

In your code, you are invoking the constructor yourself, and it raises an exception about not having enough arguments. Instead, you need to give assertRaises the callable (ukol1.SummaryFormula), and the arguments to call it with ("testtest"). Then it can call it, catching and checking for exceptions.

Ned Batchelder