Problem in converting data of XML file into hashmap

Question

I am using following code to convert a XML file data into HashMap. I had modified the old code. Now it is running properly. but only for XML file having following structure:

< root>
    < tag>
        < subtag>< /subtag>
        < subtag>< /subtag>
        :
    </tag>
    < tag>
        < subtag>< /subtag>
        < subtag>< /subtag>
        :
    < /tag>
< /root>

If i change the structure like, i introduce new sub-subtags, or i use empty tags. Then it is not working properly.

public ArrayList getTagList(Document document) {
        ArrayList Alltags = new ArrayList();
        HashMap tag = new HashMap();
        HashMap leaftag = new HashMap();
        getTagList( document.getRootElement(),Alltags,tag ,leaftag );
        return Alltags;
    }
public void getTagList(Element element,ArrayList Alltags, HashMap tag,HashMap leaftag ) {
    for ( int i = 0, size = element.nodeCount(); i < size; i++ ) {
        Node node = element.node(i);
        if ( node instanceof Element ) {
            getTagList( (Element) node,Alltags, tag,leaftag );
            if(((Element) node).isTextOnly()){                  
                leaftag.put(node.getName(), node.getText());
            }
            else{
                tag.put(node.getName(), leaftag);
                Alltags.add(tag);
                tag= new HashMap();
                leaftag= new HashMap();
            }
        }//End If
    }//End For
}

Plese help & suggest what extra changes i can do? So all sort of XMLs can be converted into HashMap

If you suggest xStream. Please tell me how can i parse a XML file using xStream directly.

Answer 1

In your loop, you are assigning a new hashmap to internalTags variable. So the next addings will fall into this new hashmap (not the original one). Please use another variable name like subInternalTags or something! :)

Answer 2

Not sure how to explain... but you put tags in internalTags on one level but only copy them in roottags on the next level, thus you 'loose' the internalTags for the last level...

Anyway your algo is difficult to understand, what are the different maps and list meant for...

Try to explain what you try to achieve...

Answer 3

Do you want a map of nested maps or are you just looking for a generic key value structure for representing any XML document? If it is the latter check out example 1 from my blog post on Service Data Objects (SDO).

• http://bdoughan.blogspot.com/2010/09/processing-atom-feeds-with-sdo.html

Answer 4

I had done it using google multimap. thanks for all of your support.

Although your suggestions are welcome