ansaurus

Question

Hyperlink in Table

Answer 1

+1 A:

You need to put some content in the a tag (note the NAME OF YOUR LINK I added). And also you haven't added quotes around the href attribute (note the \" I added).

while ($rows = mysql_fetch_assoc($run)) {
    echo "<tr>";
    echo "<td>". $rows['file_ref'] ."</td>";
    echo "<td>". $rows['file_name'] ."</td>";
    echo "<td>". $rows['owner'] ."</td>";
    echo "<td><a href=\"" . $rows['url'] . "\">NAME OF YOUR LINK</a></td>";
    echo "<td><a href=\"add_borrower.php?id=" . $rows['id'] . "\">Borrow</a></td>";
    echo "</tr>";
}

Also your coding conventions are rather inconsistent, (your mixing both kinds of quotes. You should use one or the other. See the following examples of how to quote consistently.

while ($rows = mysql_fetch_assoc($run)) {
    echo "<tr>";
    echo "<td>{$rows['file_ref']}</td>";
    echo "<td>{$rows['file_name']}</td>";
    echo "<td>{$rows['owner']}</td>";
    echo "<td><a href=\"{$rows['url']}\">NAME OF YOUR LINK</a></td>";
    echo "<td><a href=\"add_borrower.php?id={$rows['id']}\">Borrow</a></td>";
    echo "</tr>";
}

Or:

while ($rows = mysql_fetch_assoc($run)) {
    echo '<tr>';
    echo '<td>'.$rows['file_ref'].'</td>';
    echo '<td>'.$rows['file_name'].'</td>';
    echo '<td>'.$rows['owner'].'</td>';
    echo '<td><a href="'.$rows['url'].'">NAME OF YOUR LINK</a></td>';
    echo '<td><a href="add_borrower.php?id='.$rows['id'].'">Borrow</a></td>';
    echo '</tr>';
}

Or:

while ($rows = mysql_fetch_assoc($run)) {
echo <<<HTML
    <tr>
        <td>{$rows['file_ref']}</td>
        <td>{$rows['file_name']}</td>
        <td>{$rows['owner']}</td>
        <td><a href="{$rows['url']}">NAME OF YOUR LINK</a></td>
        <td><a href="add_borrower.php?id={$rows['id']}">Borrow</a></td>
    </tr>
HTML;
}

Petah 2010-10-15 01:56:40

Thank u. Solved.

yash 2010-10-15 04:13:51

Answer 2

A:

You should edit you line to make it look like :

echo "<td><a href=" . $rows['url'] . ">" . $rows['url'] . "</a></td>";

you need content between your

<a>...</a>

And one more thing, if you want to speed up the rendering process, for string where you don't use variable, it would be better if you used single quotes ('). This would also allow you to put the values of your HTML tag attribute inside double quotes (") (required by the w3c xhtml and html5 standards)

Jeff 2010-10-15 02:00:19

The comment about speed is hardly relevant. You would only save about 0.0000001 of a second

Petah 2010-10-15 02:06:13

Thank u. Solved.

yash 2010-10-15 04:14:33

@Petah: On the long run double quotes run slower than single quotes. In small web app it wont change a lot but in bigger ones, processing time will be cut by approximately 4%.

Jeff 2010-10-16 11:28:46

Define bigger in terms of amount of quoted code. Also when a website get big enough that a 4% slow down is significant there would be more important aspects to consider, such as caching.

Petah 2010-10-16 12:15:03

ok guys.. thank you very much =)

yash 2010-10-18 06:28:37

ansaurus

tags:

views:

answers:

Hyperlink in Table

related questions