views:

79

answers:

2
class File(object):
    def __init__(self, filename):
        if os.path.isfile(filename):
            self.filename = filename
            self.file = open(filename, 'rb')
            self.__read()
        else:
            raise Exception('...')

    def __read(self):
        raise NotImplementedError('Abstract method')

class FileA(File):
    def __read(self):
        pass

file = FileA('myfile.a')

# NotImplementedError: Abstract method

My question: what's wrong? How I can fix my code to FileA use FileA.__read() to read the file instead of File.__read()? :S

Thank you in advance.

+6  A: 

Prefixing an attribute with double underscores doesn't make the attribute private, it simply makes polymorphism impossible because the attribute name gets mangled with the current class name. Change it to a single underscore prefix instead.

Ignacio Vazquez-Abrams
Better still, simply avoid all fooling around with "privacy" until you have an actual problem with someone actually corrupting your class using an attribute or method incorrectly. Until someone **actually** misunderstands your API, do not use any privacy constructs of any kind.
S.Lott
Oh my! That was it. :|I always confuse Python rules with PHP rules. Sorry for that and thank you for the answer, guys! :)
pf.me
Worth noting that the under/dunder convention is useful for suggesting the difference between public methods that are going to be relatively reliable vs. private ones that may change at any moment.
Paul McMillan
The double underscore prefix isn't convention, it's syntactic sugar that results in mangling.
Ignacio Vazquez-Abrams
+1  A: 

You can also leave the method undefined in the base class to achieve the same effect.

import os
class File(object):
    def __init__(self, filename):
        if os.path.isfile(filename):
            self.filename = filename
            self.file = open(filename, 'rb')
            self._read()
        else:
            raise Exception('...')
class FileA(File):
    def _read(self):
        pass
file = FileA('myfile.a')

It is invaluable to the understanding of Python classes to have this understanding of class inheritance.

freegnu