ansaurus

Question

Dynamic title in php

Answer 1

+8 A:

First, the file header.php is being included from within a function, so it does not have access to the global variable $t. You will need to do one of the following:

In `functions.php`:

function get_header() {
    global $t;
    require_once('includes/header.php');
}

Or, in `header.php`:

<?php //include('functions.php')
global $t;
?>
<!DOCTYPE html>
<!-- etc -->

That way, the variable you have declared will be available to the function's local variable scope.

Second, you need to call the function with either double quotes or no quotes at all. Single quotes will not parse a variable.

Right

title($t);
title("$t");
title("{$t}");

Wrong

title('$t');

Here is the PHP Manual Page on the String datatype -- be sure to check out single quoted strings versus double quoted strings.

Nitpicky Things:

You should always use the full opening tags (<?php), and not the short open tags (<?)
Your functions, like title(), should always return a value, and you can echo that, rather than echoing directly from inside the function.
The strleft() function you implemented, though clever, already exists. See: strstr() ~~Actually, this function does the opposite of what you want; I mis-remembered what it did. Carry On.~~ EDIT AGAIN: No, apparently I was right, you pass the optional third parameter as true. You should generally use functions that already exist because, with certain exceptions, they will be faster.
- A Notable exception to this rule is array_rand()

Dereleased 2010-10-29 16:18:36

the strleft() is part of a function for getting the page url that got from page online.

ellisgeek 2010-10-29 17:27:07

and i alredy tried no quotes

ellisgeek 2010-10-29 17:27:44

Why `<?php` *always*?

Jason 2010-10-29 18:30:03

OK, I found the problem, I will update my post in a moment to reflect the new solution.

Dereleased 2010-10-29 19:30:13

@Jason: Two reasons. First, because `<?` is a generic syntax which is also used in other languages, such as XML; in this case, the short open tag is ambiguous and could lead to errors involving PHP trying (and failing) to parse XML. Second, because it has to be enabled in php.ini and you cannot always guarantee that it will be, nor can you always be sure you can effect it so; short open tags break portability.

Dereleased 2010-10-29 19:36:13

Thanks, I just figured it out my self

ellisgeek 2010-10-29 20:03:12

Answer 2

A:

Try to change <? title('$t')?> to <? title($t)?> inn your code

Christian 2010-10-29 16:18:45

tried that already

ellisgeek 2010-10-29 17:25:03

ansaurus

tags:

views:

answers:

Dynamic title in php

In `functions.php`:

Or, in `header.php`:

Right

Wrong

Nitpicky Things:

related questions

ansaurus

tags:

views:

answers:

Dynamic title in php

In functions.php:

Or, in header.php:

Right

Wrong

Nitpicky Things:

related questions

In `functions.php`:

Or, in `header.php`: