views:

56

answers:

2

I think what I'm trying to do is pretty simple, and I'm really not sure why this isn't working. I'm using Rails 3.

Essentially, I'm just trying to select the distinct values from a column in an existing model, and print them out all. For the most part, this works but the .each loop in my view also ends up printing the entire array at the end of the loop. (

I a model called Attractions, and each attraction has a Category (right now the Category is hardcoded in the DB for simplicity).

This is the Attraction Model and a class method "all_categories" defined...

class Attraction < ActiveRecord::Base

  def self.all_categories
    Attraction.select("DISTINCT category")
  end

end

This is the Attraction Controller

class AttractionsController < ApplicationController
  def index
    @categories = Attraction.all_categories
    @attractions = Attraction.find(:all)
  end

  def show
    @attraction = Attraction.find(params[:id])
  end
end

This is the code in my view that is causing trouble - no rocket science, just a simple iterator, ...

  <%= @categories.each do |c| %>
    <%= c.category %><br/>
  <% end %>

Pretty simple, right? This is all running fine, BUT this is what I see when that code segment is run:

Architecture
Art
Fashion
Music
[#<Attraction category: "Architecture">, #<Attraction category: "Art">, #<Attraction category: "Fashion">, #<Attraction category: "Music">]

Why is the array at the end printed? All I want is a list of the categories:

Architecture
Art
Fashion
Music

Obviously, I'm new to Ruby/Rails, and I've tried to search all over for a solution to this. Is there something obvious that I'm missing?

Appreciate any help.

+3  A: 

Change

<%= @categories.each do |c| %> 

to

<% @categories.each do |c| %>

You only want the side effects on the block of the #each method, you don't want interpolation of the returned value.

DigitalRoss
it's exact same line ?
shingara
`<%=` vs `<% ` ...
DigitalRoss
Thank you so much!
Tarun
A: 

It's because it's what happen when you do

def self.all_categories
  Attraction.select("DISTINCT category")
end

It's create an Attraction Object with attribute define by your field. You can do

def self.all_categories
  Attraction.select("DISTINCT category").map(&:category)
end
shingara
This works too, although I do have to implement the solution suggested by DigitalRoss in conjunction to avoid the array printing at the end. Thanks!
Tarun