views:

785

answers:

3

When I read a directory in Perl with opendir, readdir, and closedir, the readdir function doesn't seem to read the files in any specific order (that I can tell).

I am reading a directory that has subdirectories named by epoch timestamp:

1224161460
1228324260
1229698140

I want to read in these directories in numerical order, which would put the oldest directories first.

When I use readdir, the first one it reads is 1228324260, which is the middle one. I know I could put the directory contents in an array and sort the array, but is there an option I can pass to readdir to read in sorted order? Or maybe a more elegant way of accomplishing this than pushing everything into array and sorting the array? There are probably modules out there to do this too, but it is difficult to get modules installed in our environment, so unless it is a built-in module I'd prefer to not use modules...

Thanks!

EDIT As requested, I am posting the code that I am using:

opendir( DATA_DIR, $data_dir ) || die "Cannot open $data_dir\n";
while ( my $name = readdir(DATA_DIR) ) {
    next if ( $name eq '.' or $name eq '..' );
    my $full_path = "${data_dir}/${name}";
    next unless ( -d $full_path );
    &process_dir($full_path);
}
closedir(DATA_DIR);
+5  A: 

readdir can be called in array context, so just do this:

opendir( DATA_DIR, $data_dir) || die "Cannot open $data_dir\n";
my @files = sort { $a <=> $b } readdir(DATA_DIR);
while ( my $name = shift @files ) {
...
Andrew Barnett
You don't need the { $a <=> $b } block; the default suffices here.
Svante
NO, the default does NOT suffice. The default sorts lexically, not numerically. Timestamps preceding 2001-09-09T01:46:40 would sort as later than most timestamps after it, because it broke the 1,000,000,000 seconds barrier.
Leon Timmermans
Really though, opendir is overkill here. Your best bet would be to use glob() ... no directory handles to worry about.
Robert P
+2  A: 

You can try it with a bit of Glob magic, glob appears to function in a sorted manner, so this:

#  Glob in scalar context iterates the result set internally
while( defined( my $dir = glob($dir . '/*' ) ) ){ 
     print $dir, "\n";
    # $dir is fed ordered and with full names. 
}

or

# Glob in list context returns all results. 
for( glob($dir.'/*' ) ){ 
  print $dir , "\n";
  # also ordered. 
}

should work. Just be careful with glob, because this:

 for(0..20){ 
   printf "%30s|%30s\n", glob($dir.'/*' ), glob($dir.'/*' );
 }

does something semi-magical, and prints the dir contents twice on each line. ie:

/foo/bar/a  |  /foo/bar/a
/foo/bar/b  |  /foo/bar/b
/foo/bar/c  |  /foo/bar/c
/foo/bar/d  |  /foo/bar/d
Kent Fredric
This is probably the best way to do it. opendir is really overkill here.
Robert P
+3  A: 

Just throw a sort in front of any list operator that you want to re-order. You don't need to store the results in an array either. You can use a foreach:

opendir my($dh), $dirname or die "Could not open directory [$dirname]: $!";

foreach my $file ( sort { $a <=> $b } readdir $dh )
    {
    ...
    }
brian d foy
++ for simplification, but I think someone broke your code markup (the sort block).
converter42
Ah, yeah, the pre blocks don't like the angle brackets, even though it comes out nicely in the preview.
brian d foy