pagination incrementing problem

Question

I have the following code, which is the basis for pagination in a larger application. However, it does not work, as although I should be obtaining the value of pg from the url, pg never goes higher than 2. For some reason, next = pg+1; seems to always see pg as 1, regardless of what is passed on the url. It is a similar problem with last. I assume I am overriding the value obtained from GET, but I am unsure where.

The problem seems to be in how I am working out $max and the limit, as instead of 0, 10, -10, 10 gets passed. Also the ifcode before $max does not seem to succeed in stopping pg from being 0.

<?php
if (isset($_GET["pg"])) {
    $pg = $_GET["pg"];
} else $pg = 1;
$con = mysql_connect("localhost","","");
if(!$con) {
    die('Connection failed because of' .mysql_error());
}
mysql_select_db("ebay",$con);

if ($pg < 1) {
    $pg = 1;
} elseif ($pg > $last) {
    $pg = $last;
}
$table = 'AUCTIONS';
$page_rows = 10;
$max = ' limit ' .($pg - 1) * $page_rows .', ' .$page_rows;
$rows = getRowsByArticleSearch($query, $table, $max);
$rowcount = count($rows);
echo $rowcount;
$last = ceil($rowcount/$page_rows);
$page_rows = 10;
$rowcount = 2;
// Would normally obtain the number of rows returned, but database stuff is snipped for brevity
$last = ceil($rowcount/$page_rows);
if ($pg < 1) {
    $pg = 1;
} elseif ($pg > $last) {
    $pg = $last;
}
$self = htmlspecialchars($_SERVER['PHP_SELF'],ENT_QUOTES,'utf-8');
echo " <a href='$self?pg=1'> <<-First</a> ";
$previous = $pg-1;
echo " <a href='$self?pg=$previous'> <-Previous</a> ";
echo "---------------------------";
$next = $pg+1;
echo " <a href='$self?pg=$next'>Next -></a> ";
echo " <a href='$self?pg=$last'>Last ->></a> ";

Answer 1

Here's your problem:

$last = ceil($rowcount/$page_rows);

That's setting $last to be 1, and then you have:

if ($pg > $last) {
  $pg = $last;
}

Edit: I wonder if you meant this, instead:

$last = ceil($page_rows/$rowcount);

Edit again: as per Cassy's answer, you probably really just need to set the right values for these variables:

$page_rows = 10;
$rowcount = 2;

Answer 2

The code is correct, however, the data is wrong.

When you have

$page_rows = 10;
$rowcount = 2;

it actually means, that you have 2 rows displayed on pages which will display 10 rows each. This makes it 1 page in total.

Change it to

$page_rows = 10;
$rowcount = 200;

and voila, you will get your pagination.

Answer 3

based on the now revised question:

$rowcount = count($rows);

will naturally always return 10, as you're limiting the result

... LIMIT 10;

But this might help:

SQL CALC FOUND ROWS Example:

mysql> SELECT SQL_CALC_FOUND_ROWS * FROM tbl_name
    -> WHERE id > 100 LIMIT 10;
mysql> SELECT FOUND_ROWS();

The first query will still return your articles, while the second will return the number of rows the previous select would have had if not using the LIMIT clause.

Hope that helps.