views:

2526

answers:

8

I have a method like this:

public static <T> boolean isMemberOf(T item, T[] set)
{
    for (T t : set) {
        if (t.equals(item)) {
            return true;
        }
    }
    return false;
}

Now I try to call this method using a char for T:

char ch = 'a';
char[] chars = new char[] { 'a', 'b', 'c' };
boolean member = isMemberOf(ch, chars);

This doesn't work. I would expect the char and char[] to get autoboxed to Character and Character[], but that doesn't seem to happen.

Any insights?

+10  A: 

There is no autoboxing for arrays, only for primitives. I believe this is your problem.

Eddie
Yes, that's the problem. That seems so broken to me... or at least, counter-intuitive.
David
And a limitation of Java, IMHO.
Peter Lawrey
I personally don't like autoboxing, as it's a comparatively expensive operation I'd like to be able to prevent unless truly necessary.
Eddie
As long as you are within the object cache, the cost autoboxing and unboxing is notional. Auto-boxing is never necessary however.
Peter Lawrey
+4  A: 

Why would char[] be boxed to Character[]? Arrays are always reference types, so no boxing is required.

Furthermore, it would be hideously expensive - it would involve creating a new array and then boxing each char in turn. Yikes!

Jon Skeet
From a technical perspective, I totally agree with you. From a user-centered perspective, it seems like this should "just work". (I suppose this wouldn't be a problem at all if it weren't for the use of primitive types in the first place)
David
A: 

This appears to be by design, both to avoid such an expensive autoboxing operation, and because generics have to be backwards-compatible with the existing Java bytecode.

See this article and this bug, for example.

jleedev
+1  A: 

Arrays are a low-level implementation type of thing. char[] will be a contiguous area of memory with two-byte chars. Character[] will be a contiguous area of memory with four or eight-byte references. You cannot get a Character[] to wrap a char[]. However a List<Character> could wrap a char[].

Arrays of references are not usually a good idea unless you are writing low-level code. You could, if you wish, write or obtain an equivalent of java.util.Arrays.asList.

Tom Hawtin - tackline
A: 

A simpler way to do this is

char ch = 'a';
String chars = "abc";
boolean member = chars.indexOf(ch) >= 0;
Peter Lawrey
True, but I was hoping to create a method that I could use with any type.
David
A: 

Correct, there is no autoboxing for arrays (which results in weirdness in cases like int[] ints; ...; Arrays.asList(ints) - asList returns a List containing a single Object, the array!)

Here's a simple utility to box an array.

public static Integer[] boxedArray(int[] array) {
 Integer[] result = new Integer[array.length];
 for (int i = 0; i < array.length; i++)
  result[i] = array[i];
 return result;
}

You will need a different version for each primitive type, of course.

A: 

You could use reflection to get a method that works for all types of arrays, but you would lose type safety, so this is probably not what you want.

import java.lang.reflect.Array
public static boolean isMemberOfArray(Object item, Object array)
{
    int n = Array.getLength(array)
    for (int i = 0; i < n; i++) {
        if (Array.get(array, i).equals(item)) {
            return true;
        }
    }
    return false;
}
newacct
A: 

As others have mentioned, there is no autoboxing for arrays of primitives. If you want to use your method with primitive arrays, you will need to provide an overload for each primitive type. This seems to be the standard way of doing things in the class libraries. See the overloads in java.util.Arrays, for example.

Ben Lings