views:

3349

answers:

5

An Enum in Java implements the Comparable interface. It would have been nice to override Comparable's compareTo method, but here it's marked as final. The default natural order on Enum's compareTo is the listed order. Does anyone know why a Java Enum has this restriction?

A: 

If you want to change the natural order of your enum’s elements, change their order in the source code.

Bombe
Yup, that's what I wrote in the original entry :)
neu242
Yes but you don’t really explain why you’d want to override compareTo(). So my conclusion was that you are trying to do Something Bad™ and I was trying to show you a more correct way.
Bombe
I don't see why I should have to sort the entries by hand when computers does that much better than me.
neu242
In enumerations it’s assumed that you ordered the entries in that specific way for a reason. If there is no reason you are better off using <enum>.toString().compareTo(). Or maybe something different altogether, like maybe a Set?
Bombe
The reason this came up is that I have an Enum with {isocode,countryname}. It was manually sorted on countryname, which works as intended. What if I decide I want to sort on isocode from now on?
neu242
Then you probably shouldn’t use an enum. As I said.
Bombe
my 2 cents: iso codes change from time to time. You shouldn't store those in code but rather in something data-driven like a config file or a database.
Mr. Shiny and New
+15  A: 

For consistency I guess... when you see an enum type, you know for a fact that its natural ordering is the order in which the constants are declared.

To workaround this, you can easily create your own Comparator<MyEnum> and use it whenever you need a different ordering:

enum MyEnum
{
    DOG("woof"),
    CAT("meow");

    String sound;    
    MyEnum(String s) { sound = s; }
}

class MyEnumComparator implements Comparator<MyEnum>
{
    public int compare(MyEnum o1, MyEnum o2)
    {
     return -o1.compareTo(o2); // this flips the order
     return o1.sound.length() - o2.sound.length(); // this compares length
    }
}

You can use the Comparator directly:

MyEnumComparator c = new MyEnumComparator();
int order = c.compare(MyEnum.CAT, MyEnum.DOG);

or use it in collections or arrays:

NavigableSet<MyEnum> set = new TreeSet<MyEnum>(c);
MyEnum[] array = MyEnum.values();
Arrays.sort(array, c);

Further information:

Zach Scrivena
Custom comparators are only really effective when supplying the Enum to a Collection. It doesn't help as much if you want to make a direct comparison.
Martin OConnor
Yes, it does. new MyEnumComparator.compare(enum1, enum2). Et voilá.
Bombe
Zach Scrivena
+5  A: 

Enumeration values are precisely ordered logically according to the order they are declared. This is part of the Java language specification. Therefore it follows that enumeration values can only be compared if they are members of the same Enum. The specification wants to further guarantee that the comparable order as returned by compareTo() is the same as the order in which the values were declared. This is the very definition of an enumeration.

Martin OConnor
A: 

Another example: and enum of playing cards with Rank and Suit members where you want compareTo to return not the lexical ordering of the 52 values but the rank comparison. Btw, because the automatic compareTo compares on lexical order, it will never return 0.

random coder
A: 

Providing a default implementation of compareTo that uses the source-code ordering is fine; making it final was a misstep on Sun's part. The ordinal already accounts for declaration order. I agree that in most situations a developer can just logically order their elements, but sometimes one wants the source code organized in a way that makes readability and maintenance to be paramount. For example:


  //===== SI BYTES (10^n) =====//

  /** 1,000 bytes. */ KILOBYTE (false, true,  3, "kB"),
  /** 106 bytes. */   MEGABYTE (false, true,  6, "MB"),
  /** 109 bytes. */   GIGABYTE (false, true,  9, "GB"),
  /** 1012 bytes. */  TERABYTE (false, true, 12, "TB"),
  /** 1015 bytes. */  PETABYTE (false, true, 15, "PB"),
  /** 1018 bytes. */  EXABYTE  (false, true, 18, "EB"),
  /** 1021 bytes. */  ZETTABYTE(false, true, 21, "ZB"),
  /** 1024 bytes. */  YOTTABYTE(false, true, 24, "YB"),

  //===== IEC BYTES (2^n) =====//

  /** 1,024 bytes. */ KIBIBYTE(false, false, 10, "KiB"),
  /** 220 bytes. */   MEBIBYTE(false, false, 20, "MiB"),
  /** 230 bytes. */   GIBIBYTE(false, false, 30, "GiB"),
  /** 240 bytes. */   TEBIBYTE(false, false, 40, "TiB"),
  /** 250 bytes. */   PEBIBYTE(false, false, 50, "PiB"),
  /** 260 bytes. */   EXBIBYTE(false, false, 60, "EiB"),
  /** 270 bytes. */   ZEBIBYTE(false, false, 70, "ZiB"),
  /** 280 bytes. */   YOBIBYTE(false, false, 80, "YiB");

The above ordering looks good in source code, but is not how the author believes the compareTo should work. The desired compareTo behavior is to have ordering be by number of bytes. The source-code ordering that would make that happen degrades the organization of the code.

As a client of an enumeration i could not care less how the author organized their source code. I do want their comparison algorithm to make some kind of sense, though. Sun has unnecessarily put source code writers in a bind.

Thomas Paine