views:

2585

answers:

3

I'm trying to test a controller and I got this error. I understand the error, but don't know how to fix it.

test: on CREATE to :user with completely invalid email should respond with 
  redirect
(UsersControllerTest):ActionController::RedirectBackError: 
  No HTTP_REFERER was set in the request to this action, 
  so redirect_to :back could not be called successfully. 
If this is a test, make sure to specify request.env["HTTP_REFERER"].

Specify it where? I tried this:

setup { post :create, { :user => { :email => 'invalid@abc' } }, 
  { 'referer' => '/sessions/new' } }

But got the same error.

Specify it with what, exactly? I guess the URI of the view I want it to go back to:

'/sessions/new'

Is that what they mean?


OK, so it turns out they mean do this:

setup do
  @request.env['HTTP_REFERER'] = 'http://localhost:3000/sessions/new'
  post :create, { :user => { :email => 'invalid@abc' } }, {}
end

Can someone tell me where that's documented? I'd like to read up on the context of that information.

What if the domain is not "localhost:3000"? What if it's "localhost:3001" or something? Any way to anticipate that?

Why doesn't this work:

setup { post :create, { :user => { :email => 'invalid@abc' } }, 
  { 'referer' => '/sessions/new' } }

The Rails docs specifically say that's how you set the headers.

+9  A: 

Their recommendation translates to the following:

setup do
  @request.env['HTTP_REFERER'] = 'http://test.com/sessions/new'
  post :create, { :user => { :email => 'invalid@abc' } }
end
James A. Rosen
Oh, wait. Sorry, I did it wrong. You were right.
Ethan
A: 
setup do
  @request.env['HTTP_REFERER'] = 'http://test.com/sessions/new'
  post :create, { :user => { :email => 'invalid@abc' } }
end

In Rails 2.2.2, the above block never ran actual test. Saying that

post :create, { :user => { :email => 'invalid@abc' } }

line did not run. You can simply get rid of setup block and use

@request.env['HTTP_REFERER'] = 'http://test.com/sessions/new'
post :create, { :user => { :email => 'invalid@abc' } }

instead. And it should set the referer

+1  A: 

In response to the question:

Why doesn't this work:

setup { post :create, { :user => { :email => 'invalid@abc' } }, 
{ 'referer' => '/sessions/new' } }

It doesn't work because the Rails doc you linked to documents a different class than the one you're probably using.

You linked to ActionController::Integration:Session. I'm guessing that you're writing a functional test (if you're using Test::Unit) or a controller test (if you're using Rspec). Either way, you're probably using ActionController::TestCase or a subclass thereof. Which, in turn, includes the module ActionController::TestProcess.

ActionController::TestProcess provides a get method with different parameters than the get method provided by ActionController::Integration:Session. (Annoying, eh?) The method signature is this:

 def get(action, parameters = nil, session = nil, flash = nil)

Sadly, there is no headers parameter. But at least setting @request.env['HTTP_REFERER'] works.