ansaurus

Question

Really simple question: grabbing the onSubmit event for a form

Answer 1

+6 A:

Change this:

formCheck.onSubmit = doMapping()

to this:

formCheck.onSubmit = doMapping

When you add parenthesis to the end of a function you execute that function. When you assign a function (or pass it as a parameter to another function) you need to omit the parenthesis as that is the way to retrieve a function pointer in JavaScript.

Edit: You will also need to move the declaration of the doMapping function above the assignment of that function to the onsubmit event like this (good catch tvanfosson!):

function doMapping() {
        alert("form submitted");
        return false;
    }

formCheck.onSubmit = doMapping();

However if the doMapping function is not used elsewhere you can declare the doMapping function as an anonymous function like this:

formCheck.onSubmit = function() {
        alert("form submitted");
        return false;
    }

which seems a bit cleaner to me.

Andrew Hare 2009-04-02 15:51:19

I think you'll also have to change the order since doMapping may need to be defined before you assign it as the onSubmit handler.

tvanfosson 2009-04-02 15:56:00

Thanks - I edited my answer to address your point.

Andrew Hare 2009-04-02 16:06:21

Answer 2

+3 A:

Using jQuery.

$(document).ready( function() {
    $('#commentform').submit( function() {
        alert('form submitted');
        return false;
    });
});

tvanfosson 2009-04-02 15:54:31

Answer 3

A:

Thank you! Actually I solved it another way, using both Andrew's suggestion and the window.onload event - I think the problem was partly because the element hadn't actually loaded.

window.onload = function(){
    if (document.getElementById("commentform")){
        document.getElementById("commentform").onsubmit = doMapping;
    }
}

function doMapping(){
            alert("form submitted");
            return false;
}

2009-04-02 16:07:44

Note thought that the onload event is fired after the whole page has been loaded. So should there be an image that takes long to load - usually something like google analytics your event handler will not be assinged before the user hits submit.

Rashack 2009-04-02 16:18:57

The jQuery answer handles that...

Rashack 2009-04-02 16:19:40

ansaurus

tags:

views:

answers:

Really simple question: grabbing the onSubmit event for a form

related questions