What is the best way to markup a testimonial in XHTML?

Question

I used to just use p and span elements for this... but I'm always pushing to use the right elements, and this is something I haven't really thought about before with regard to testimonials.

This is what I had in mind

<div class="testimonial">
 <blockquote>i love your products</blockquote>
 <span>Jim Testimonial-giver</span>
</div>

Does that look like the best way to do this? Is there a best practise? I looked at how the W3C markup testimonials on their site, and they have done it like this:

<blockquote>
 <p>
  <a id="aptest" name="aptest">Applied Testin.....</a>
  <br />
  <span class="QuoteAttr">-- Shane P. M...</span>
 </p>
</blockquote>

Should I just copy how the W3C did it, after all shouldn't they be correct?

Answer 1

Use the cite tag:

<div class="testimonial">
 <blockquote>i love your products</blockquote>
 <cite>Jim Testimonial-giver</cite>
</div>

Also I would probably do it like this:

<blockquote class="testimonial">
  i love your products
  <cite>Jim Testimonial-giver</cite>
</blockquote>

Just to make it slightly more semantic and clearly tie the citation with the quote. Divs should only be necessary for structural things.

Answer 2

The Mozilla.org style guide seems to prefer using q for the quotation and <cite> for the author, wrapped in a <blockquote> or a <div> with an appropriate class. HTML 5 seems to strongly frown on using <cite> for people's names; it says that it should only be used for the titles of works.

Following that model, perhaps something like this:

<blockquote class="testimonial">
  <q>I love your products!</q>
  <cite>Jim Testimonial-giver</cite>
</blockquote>

Or if you don't want to use <cite>, then:

<blockquote class="testimonial">
  <q>I love your products!</q>
  <span class="quote-attribution">Jim Testimonial-giver</span>
</blockquote>