ansaurus

Question

Onsubmit form validation function not working in IE

Answer 1

+4 A:

The problem (bizarrely) is caused by having a global variable called "parent", which you're creating here:

parent = document.getElementById("parent").value;

JavaScript has its own variable called "parent", and you're overwriting it, and hence confusing the browser. You should declare yours as a local variable, like this:

var parent = document.getElementById("parent").value;

and that will make it work . It's good practice to always use "var" for that sort of variable anyway - do it for all the variables you're using.

As for a JavaScript debugger, you can use FireBug to debug in FireFox. In Internet explorer, Visual Studio is good but expensive. Or you can use Visual Web Developer for free, via the instructions here: http://www.berniecode.com/blog/2007/03/08/how-to-debug-javascript-with-visual-web-developer-express/

RichieHindle 2009-04-26 13:50:49

OK... that fixes the issues. Thank you very much for the advice. Im new to js, so any tips are very much helpful at this point. Also, I use firebug for ff... its a great tool... i was just wondering about something similar for ie... so thanks for the links. Cheers again!

Lea 2009-04-26 13:58:27

You should look at Firebug Lite: http://getfirebug.com/lite.html It adds some of Firebug's functionality to Internet Explorer (but sadly not the debugger, as far as I know).

RichieHindle 2009-04-26 14:07:39

Answer 2

+3 A:

At a quick glance the problem seems to occur @ the line document.getElementById("parent").value

You should really be using var parent here to explicitly declare it as a local variable.

At any rate, you've alot of code in their that could be sanity checked and refactored + you've got no exception handling at all...

This block repeats 8 times... for each var...

if (age == "") {
  hideAllErrors();
  document.getElementById("ageError").style.display = "inline";
  document.getElementById("age").select();
  document.getElementById("age").focus();
  return (false);
}

That could easily be made

if(age == "") {
   DoMyFunction("age", "ageError");
}
...

function DoMyFunction(a, b)
{
  hideAllErrors();
  document.getElementById(b).style.display = "inline";
  document.getElementById(a).select();
  document.getElementById(a).focus();
  return (false);
}

And anywhere you have a document.getElementById("").value You should really be doing a check here to make sure the getElementById doesn't return null.

var name = "";
var nametemp = document.getElementById("name");
if (nametemp != null)
   name = nametemp.value;

Eoin Campbell 2009-04-26 13:54:18

Thanks for your answer, and for the tips. the way you explained is clearly more condensed, and would be easier to write also.. so thank you.

Lea 2009-04-26 14:00:21

Answer 3

+1 A:

Microsoft Visual Studio is probably the best debugger for IE, but it's quite expensive, so I would not recommend purchasing it just for the debugger. But you might want to try Visual Studio Express--I'm guessing it can also debug JavaScript in IE.

Otherwise, try Microsoft Script Editor. It comes with Office XP and Office 2003, and that link has step-by-step setup instructions.

Calvin 2009-04-26 14:00:04

Hi there, thanks for the advice and links. cheers!

Lea 2009-04-26 14:11:24

ansaurus

tags:

views:

answers:

Onsubmit form validation function not working in IE

related questions