tags:

views:

656

answers:

6

Problem: by default, PHP array_merge works like this ... it will overwrite a non-blank value with a blank value.

$foobar   =   Array('firstname'=>'peter','age'=>'32','nation'=>'');
$feebar   =   Array('firstname' => '','lastname' => 'griffin', age =>'33','nation'=>'usa');

print_r(array_merge($foobar,$feebar));    
/*
Array
(
    [firstname] =>           // <-- feebar set this to blank, NOT COOL!
    [age] => 33              // <-- feebar set this to 33, thats cool
    [lastname] => griffin    // <-- feebar added this key-value pair, thats cool
    [nation] => usa          // <-- feebar filled in a blank, thats cool.
)
*/

Question: What's the fewest-lines-of-code way to do array_merge where blank values never overwrite already-existing values?

print_r(array_coolmerge($foobar,$feebar));    
/*
Array
(
    [firstname] => peter  // <-- don't blank out a value if one already exists!
    [age] => 33
    [lastname] => griffin
    [nation] => usa

)
*/

UPDATE: I modified the original question example to clarify things a bit.

A: 
array_merge($feebar,$foobar)
Jeff Ober
+1  A: 

This will put duplicates into a new array, I don't know if this is what you want though.

<?php
  $foobar =   Array('firstname' => 'peter','age' => '33',);
  $feebar =   Array('firstname' => '','lastname' => 'griffin',);
  $merged=$foobar;
  foreach($feebar as $k=>$v){
    if(isset($foobar[$k]))$merged[$k]=array($v,$foobar[$k]);
    else $merged[$k]=$v;
  }
  print_r($merged);
?>

This will simply assure that feebar will never blank out a value in foobar:

<?php
  $foobar =   Array('firstname' => 'peter','age' => '33',);
  $feebar =   Array('firstname' => '','lastname' => 'griffin',);
  $merged=$foobar;
  foreach($feebar as $k=>$v) if($v)$merged[$k]=$v;
  print_r($merged);
?>

or ofcourse,

<?
  function cool_merge($array1,$array2){
    $result=$array1;
    foreach($array2 as $k=>$v) if($v)$result[$k]=$v;
    return $result;
  }

  $foobar =   Array('firstname' => 'peter','age' => '33',);
  $feebar =   Array('firstname' => '','lastname' => 'griffin',);
  print_r(cool_merge($foobar,$feebar));
?>
elzapp
+3  A: 

Well, if you want a "clever" way to do it, here it is, but it may not be as readable as simply doing a loop.

$merged = array_merge(array_filter($foo, 'strval'), array_filter($bar, 'strval'));

edit: or using +...

Matt
Thanks for that one. Avoiding a loop can be seen as a kind of "useless cleverness" on some level perhaps -- but it's just nice to not have to *always* use loops when something like map, select, or a list comprehension (as implemented in some other languages) seems more concise.
dreftymac
Using 'trim' instead of 'strval' will also clear out items which only contain whitespace.
too much php
+4  A: 

Try this:

$merged = array_map(
    create_function('$foo,$bar','return ($bar?$bar:$foo);'),
    $foobar,$feebar
);

Not the most readable solution, but it should replace only non-empty values, regardless of which order the arrays are passed..

Calvin
Thanks for that one.
dreftymac
+2  A: 

Adjust to your needs:

# Replace keys in $foo
foreach ($foo as $key => $value) {
    if ($value != '' || !isset($bar[$key])) continue;
    $foo[$key] = $bar[$key];
}

# Add other keys in $bar
# Will not overwrite existing keys in $foo
$foo += $bar;
soulmerge
Thanks for that one.
dreftymac
+1  A: 

If you also want to keep the values that are blank in both arrays:

array_filter($foo) + array_filter($bar) + $foo + $bar
Russ