tags:

views:

266

answers:

1

Hey,

I'm trying to make some simple XML with Java and org.w3c.dom, but I got stuck when I try to append a child to a child, something like this:

<root>
     <child>
          <childOfTheChild>Some text</childOfTheChild>
     </child>
</root>

I tried quite some variations of this (like first appending the child and than creating childOfTheChild etc.):

Element root = doc.getDocumentElement();

Element child = doc.createElement("child");
Element childOfTheChild = doc.createElement("childOfTheChild ");

Text st = doc.createTextNode("Some text");

childOfTheChild.appendChild(st);
child.appendChild(childOfTheChild );

root.appendChild(child);

And I always get the same result, which is:

<root>
     <child>null</child>
</root>

Is there a problem in this code or it might be something else?

Edit:

Printing function works ok with some test XMLs otherwise... So, the function without some beauty corrections:

//Call System.out.println( print(dokument.getFirstChild()) );
private String print(Node node) {

    String txt = "";  //xml string presentation

    //Get the primary node name and any existing attributes, like <myNode att1='some val'>
    if (node.getNodeType() == node.ELEMENT_NODE) 
    {
        //The name
        txt += "<" + node.getNodeName();

        //Insert the attributes
        if (node.hasAttributes()) 
        {
            NamedNodeMap atts = node.getAttributes();
            for (int i = 0; i < atts.getLength(); i++) {
                Node atts = atts.item(i);
                txt += " " + atts.getNodeName() + " = '" + atts.getNodeValue() + "'";
            }
        }
        txt +=  ">\n";
    }

    int nChilds = -1;

    //Get any existing child nodes, so the <root><child1></child1></root>
    if (node.hasChildNodes()) 
    {
        NodeList childs = node.getChildNodes();
        nChilds  = childs.getLength();


        if (nChilds == 1) 
        {
            txt += childs.item(0).getNodeValue();
        } 
        else 
        {
            for (int j = 0; j < nChilds; j++) {
                txt += print(childs.item(j));
            }
        }
    }

    //And the ending of the primary node, like </root>
    if (node.getNodeType() == node.ELEMENT_NODE) 
    {
        txt += "</" + node.getNodeName();
        txt +=  ">\n";
    }
    return txt;
}
+1  A: 

Works fine for me?:

import static org.junit.Assert.assertTrue;

import java.io.StringWriter;

import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
import javax.xml.transform.Transformer;
import javax.xml.transform.TransformerConfigurationException;
import javax.xml.transform.TransformerException;
import javax.xml.transform.TransformerFactory;
import javax.xml.transform.TransformerFactoryConfigurationError;
import javax.xml.transform.dom.DOMSource;
import javax.xml.transform.stream.StreamResult;

import org.junit.Test;
import org.w3c.dom.DOMImplementation;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
import org.w3c.dom.Text;

public class DomTest {

    @Test
    public void testDom() throws Exception {
        Document document = createEmptyDocument();

        Element root = document.getDocumentElement();
        Element child = document.createElement("child");
        Element childOfTheChild = document.createElement("childOfTheChild");
        Text st = document.createTextNode("Some text");
        childOfTheChild.appendChild(st);
        child.appendChild(childOfTheChild);
        root.appendChild(child);

        assertTrue(serialise(document).contains("Some text"));
    }

    private Document createEmptyDocument() throws ParserConfigurationException {
        DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
        DOMImplementation domImpl = dbf.newDocumentBuilder()
                .getDOMImplementation();
        Document document = domImpl.createDocument(null, "root", null);
        return document;
    }

    private String serialise(Document document)
            throws TransformerFactoryConfigurationError,
            TransformerConfigurationException, TransformerException {
        TransformerFactory xff = TransformerFactory.newInstance();
        Transformer xf = xff.newTransformer();
        StringWriter sw = new StringWriter();
        xf.transform(new DOMSource(document), new StreamResult(sw));
        return sw.toString();
    }
}
toolkit
OK, thanks! It seems like the printing function of mine has some errors, will debug :) . It is meant more like dom exercising, that is why it is like it is not with serialization. Thanks again!
Armen Ablak
Note: An alternative to the Transformer approach to serialisation is to use DOM-LS. See http://stackoverflow.com/questions/620250/java-domimplementationls
toolkit