ansaurus

Question

PHP logical coding style

Answer 1

A:

I personally work on a CMS that has the latter version, and I am having a very hard time reading it.

2ndly, model/controller code within view's is a great Italian dish.

Ólafur Waage 2009-05-18 09:57:08

Answer 2

+5 A:

I would ditch both and code the PHP away from any presentation-layer specific HTML. Otherwise things get very nasty, very quickly for anything bigger than 'Hello World' :)

You are shooting yourself in the foot if you want to modify the code later. I would try and kill off this problem by porting to a proper CMS/Abstract presentation.

Neither look good. I wouldn't want to maintain code in either style. save time later by spending time now cleaning it up properly.

Even something as basic as moving your HTML into externally loaded format strings and running them through sprintf() or similar might be better than the current situation. And you say you have a mix of these coding styles !?!

good luck to you sir!

Both styles should be relegated to the tomb of dynamic internet growing pains. Take a peek through some open source PHP projects to see a good, maintainable coding style in action. Things like http://sourceforge.net/projects/wikipedia MediaWiki show a good mix of HTML-In-Source and separation (although it is not perfect IMHO)

Aiden Bell 2009-05-18 10:01:49

ofc cleaning all of that up is going to be an absolute pain, and take ages! Sometimes it *is* better just to live with what you've got until the next rebuild-from-scratch :)

2009-05-18 10:04:19

Rebuilding from scratch anyway might be better. Problem is, I presume from the state of that code that no proper docs exist! So rebuilding may entail looking through the original code, which would give anyone a headache and brain fuzz.

Aiden Bell 2009-05-18 10:07:09

My thoughts exactly, I can't modify all, however, I am forced to add new functionalities to the existing modules...

Tupak Goliam 2009-05-18 10:09:08

If there is a good separation in module interface through function/class definition or URL then you may be able to rewrite as you go without changing the API or external presentation. Careful of dragons tho.

Aiden Bell 2009-05-18 10:13:39

Answer 3

+2 A:

There is a third option: templates. Templates are more readable than glue or random emission of ascii vomit. I just tend to use HEREDOCd strings and str_replace, thus:

$template = <<<TEMPLATE
<html>
<head>
<title>{TITLE}</title>
</head>
<body>
<div id='nav'>{NAV}</div>
<div id='content'>{CONTENT}</div>
</body>
TEMPLATE;

$data = array (
"{TITLE}" => "Page title example",
"{NAV}" => buildNav(),
"{CONTENT}" => buildContent());

str_replace(array_keys($data),array_values($data), $template);

2009-05-18 10:03:05

Answer 4

+2 A:

I tend to go for something in the middle. If I'm calling fifteen different functions to generate a select <option>, why not just have one function that does everything and creates the complete markup?

Something like this (completely made up example):

<select>
<?php
    foreach (database_query() as $row)
        echo gen_select($row)
?>
</select>

and somewhere else

function gen_select($row) {
    // do something horrifically complicated with the data (creating some variables to make the output easier to follow

    return "<option class=\"$class\">$text</option>";
}

Oli 2009-05-18 10:05:50

Answer 5

A:

I think HTML and PHP should be seperated as much as possible. It makes the whole code easier to read and creates a clear structure. That means for me that PHP should not output HTML, since you can use HTML to do that part...

So I'd also prefer the last example, but with one difference: I think using the bracket-style mixed into HTML makes it very hard to read the code. The if...endif style is the better alternative I think. Also printing HTML with PHP seems unlogic.

I'd do it this way:

 <td valign="top"><form name="form5" method="GET" action=""><select name="m" onchange="this.form.submit()">;
 <? if ( empty($_GET['p']) ): ?>
     <option value=" ">All</option>
 <? else: ?>
     <option value="<?=$_GET['m']?>"><?=$_GET['m']?</option>
 <? endif; ?>
 <?
 $query = "SELECT DISTINCT maoie FROM ".$BD."site";
 $res = mysql_query($query);
 while ( $row = mysql_fetch_assoc($res) ):
 ?>
     <? if( !empty($row['maoie']) ): ?>
         <option  value="<?=$row['maoie']?>"><?=$row['maoie']?></option>
     <? endif; ?> 
 <? endwhile; ?>
 </select></form></td>
 <? echo add_more_stuff(); ?>

At least this is a bit more logic. Nevertheless things like database interaction should be excluded to somewhere else in your web application. If you seperate the data and the design of your page it gets much clearer.

Nevertheless I think using PHP as a template language is totally fine as long as you only use some replacement variables and simple if-statements.

okoman 2009-05-18 10:07:03

Answer 6

A:

Both are horrible (that's the real weakness of PHP in my opinion), but at least the first looks readable.
Problems will eventually arise once conditions (is the request POST? is the data valid?) are added, and it will lead invariably to the dreaded second kind of coding. Try to decouple view and logic: str_replacing is way better than building a string by concatenating one gazillion small pieces.

Agos 2009-05-18 10:10:38

After your first sentence I expected a 'rewrite in Python' post :)

Aiden Bell 2009-05-18 10:14:55

That would have been quite trollish, but I admit I was tempted to say it ;)

Agos 2009-05-18 10:25:26

I just spent a week ruthlessly porting my app from PHP to Python. I don't like the Python syntax much, but anything is better than inconsistent library function and '/' namespaces :S

Aiden Bell 2009-05-18 10:27:23

Answer 7

A:

No offence, but both style is from the late '90-s.

You should seriously consider refactor the system and use a template engine to separate at least the PHP and the HTML code. Even better if you can separate the "business logic" and the "display logic" part.

Csaba Kétszeri 2009-05-18 11:25:56

ansaurus

tags:

views:

answers:

PHP logical coding style

related questions