views:

1367

answers:

2

In java, if a class implements Serializable but is abstract, should it have a serialVersionUID long declared, or do the subclasses only require that?

In this case it is indeed the intention that all the sub classes deal with serialization as the purpose of the type is to be used in RMI calls.

+7  A: 

The serialVersionUID is provided to determine compatibility between a deseralized object and the current version of the class. As such, it isn't really necessary in the first version of a class, or in this case, in an abstract base class. You'll never have an instance of that abstract class to serialize/deserialize, so it doesn't need a serialVersionUID.

(Of course, it does generate a compiler warning, which you want to get rid of, right?)

It turns out james' comment is correct. The serialVersionUID of an abstract base class does get propagated to subclasses. In light of that, you do need the serialVersionUID in your base class.

The code to test:

import java.io.Serializable;

public abstract class Base implements Serializable {

    private int x = 0;
    private int y = 0;

    private static final long serialVersionUID = 1L;

    public String toString()
    {
        return "Base X: " + x + ", Base Y: " + y;
    }
}



import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;

public class Sub extends Base {

    private int z = 0;

    private static final long serialVersionUID = 1000L;

    public String toString()
    {
        return super.toString() + ", Sub Z: " + z;
    }

    public static void main(String[] args)
    {
        Sub s1 = new Sub();
        System.out.println( s1.toString() );

        // Serialize the object and save it to a file
        try {
            FileOutputStream fout = new FileOutputStream("object.dat");
            ObjectOutputStream oos = new ObjectOutputStream(fout);
            oos.writeObject( s1 );
            oos.close();
        } catch (Exception e) {
            e.printStackTrace();
        }

        Sub s2 = null;
        // Load the file and deserialize the object
        try {
            FileInputStream fin = new FileInputStream("object.dat");
            ObjectInputStream ois = new ObjectInputStream(fin);
            s2 = (Sub) ois.readObject();
            ois.close();
        } catch (Exception e) {
            e.printStackTrace();
        }

        System.out.println( s2.toString() );
    }
}

Run the main in Sub once to get it to create and save an object. Then change the serialVersionUID in the Base class, comment out the lines in main that save the object (so it doesn't save it again, you just want to load the old one), and run it again. This will result in an exception

java.io.InvalidClassException: Base; local class incompatible: stream classdesc serialVersionUID = 1, local class serialVersionUID = 2
Bill the Lizard
Good answer...@SuppressWarnings("serial") will suppress the warning message
Ryan Anderson
@Ryan: Thanks, but I typically treat warnings like errors and deal with them directly.
Bill the Lizard
...but I understand that not everyone is as dogmatic about it as I am, so your comment is appreciated.
Bill the Lizard
actually, this is incorrect. during deserialization, the serialversionuid of all the classes in the inheritance chain is taken into account, thus the lack of one on an abstract class could be problematic. i actually encountered this issue.
james
It should also be present in the first version of the class, since recompiling it with a different compiler may produce a different default serialVersionUID. Thus rendering a newly compiled version of the class (with no code changes) incompatible with the old. Check the note http://java.sun.com/j2se/1.5.0/docs/guide/serialization/spec/class.html#4100
Robin
@Robin: Strongly recommended, but not strictly necessary. I always include it to get rid of the warning, which I'm sure is there to avoid the problem you're pointing out.
Bill the Lizard
@james: I'm still trying to figure out how I'm going to test that the serialVersionUID of a base class, a static member, is taken into account during the serialization of an extending class.
Bill the Lizard
I originally accepted this answer, but given james' comment, looks like a unit test is in order to find out, so I'll have to investigate.
Yishai
@james: You're right. Thanks for the schooling. :)
Bill the Lizard
@Bill, Thanks for the research!
Yishai
+3  A: 

Yes, in general, for the same reason that any other class needs a serial id - to avoid one being generated for it. Basically any class (not interface) that implements serializable should define serial version id or you risk de-serialization errors when the same .class compile is not in the server and client JVMs.

There are other options if you are trying to do something fancy. I'm not sure what you mean by "it is the intention of the sub classes...". Are you going to write custom serialization methods (eg. writeObject, readObject)? If so there are other options for dealing with a super class.

see: http://java.sun.com/javase/6/docs/api/java/io/Serializable.html

HTH Tom

Tom