what is wrong in this ruby code?

Question

n=0
k=[]
q=[]
j=0
if n!=-1
  p=gets
    n=p.to_i
    for i in (1..n)
      l=gets
      k[i]=l.to_i
      a=a+k[i]
    end
    if a%n !=0
      q[j] = -1
      continue
    end
    a=a/n
    for i in (1..n)
      if k[i] >a
      q[j]=q[j]+(a-k[i])
      end
    end
      j=j+1
end
      for i in (1..j)
        puts(q[j])
      end

it gives me errors like this line 23 .. unexpected end line 26 unexpected end .. can any one debug ?

i have put identations now .. its in ruby !!

my inputs are in integers!!

Answer 1

It looks like you have two end's in a row about six lines up from the bottom, but it's hard to tell since the program is not consistently indented throughout.

What is the program supposed to do?

Is this homework?

Answer 2

You have end at lines 21 and 22, back to back, same indentation -- I think one of them is redundant.

Answer 3

In addition to what everyone else has suggested, the line q[j] -1 should also be q[j] = q[j] - 1.

Answer 4

I have re-indented the provided code:

n=0
k=[]
q=[]
j=0
if n!=-1
  p=gets
  n=p.to_i
  for i in (1..n)
    l=gets
    k[i]=l.to_i
    a=a+k[i]
  end
  if a%n !=0
    q[j] = -1
    continue
  end
  a=a/n
  for i in (1..n)
    if k[i] >a
      q[j]=q[j]+(a-k[i])
    end
  end
  j=j+1
end
for i in (1..j)
  puts(q[j])
end

I ran this code using IRB and I found two issues. The first is that there is no such thing as "continue". You should be able to use "next" but this statement is not within a loop. The second problem is that the variable "a" is undefined and therefore the "+" operator throws an error. My assumption is that this code is really inside another loop, probably a "while", and that the "a" variable is defined outside of it and that is the reason for the "j" variable. Maybe the "if n!= -1" is supposed to be "while n!= -1". Another problem that might show up (I didn't try it) relates to q[j] not being initialized in all situations before being used. Maybe this

if a%n != 0
  q[j] = -1
  next
end

should be

if a%n != 0
  q[j] = -1
  next
else
  q[j] = 0
end