Conditon related PHP Question

Question

$output = "<loginsuccess>";

for( $i = 1; $row = mysql_fetch_array($result); $i++ )          {


$output .="<keyword>".$_POST['keyword']."</keyword><name>".$row['url']."</name><occur>".$row['occurrences']."</occur><queryTime>".(substr($end_time-$start_time,0,5))."</queryTime>";
}

$output .= "</loginsuccess>";

I need now a simple condition where if the result is empty then i need to return no inside the xml [ login success ].

Is this a correct way....

if($row = mysql_fetch_array($result))          {

for( $i = 1; $row = mysql_fetch_array($result); $i++ )          {

$output .="<keyword>".$_POST['keyword']."</keyword><name>".$row['url']."</name><occur>".$row['occurrences']."</occur><queryTime>".(substr($end_time-$start_time,0,5))."</queryTime>";
} } else { 
    $output.="no"; 
}

Answer 1

if (mysql_num_rows($result) == 0) { 
  $output .= '<loginsuccess>no</loginsuccess>';
} else {
  // your code
}

Answer 2

Try this instead:

$i = 1;

while($row = mysql_fetch_array($result))
{
    $output .="<keyword>".$_POST['keyword']."</keyword><name>".$row['url']."</name><occur>".$row['occurrences']."</occur><queryTime>".(substr($end_time-$start_time,0,5))."</queryTime>";

    $i++;
}

if ($i == 1)
    $output .= "no";

Answer 3

Wont the for-loop simply be skipped when there are no rows? Otherwise you might want to use mysql_num_rows to count the number of rows in your result set.

Answer 4

Just a quick note, I would do what Schnalle does, but in your code I would change the for loop to a while loop as you are not doing anything with the $i

while($row = mysql_fetch_row($result)){

In total I would write you code like this:

$output = '<loginsucces>';
if(mysql_num_rows($result)){
  while($row = mysql_fetch_row($result)){
    $output .="<keyword>".$_POST['keyword']."</keyword><name>".$row['url']."</name><occur>".$row['occurrences']."</occur><queryTime>".(substr($end_time-$start_time,0,5))."</queryTime>";
  }
} else {
  $output .= 'no';
}
$output .= '</loginsucces>';

Also It owuld be even better not to mix logic and output, but that would be overkill in this situation.