views:

2738

answers:

7

Hello, I'm using php to pass a login form when required, and here is the code:

      $htmlForm = '<form id="frmlogin">'.
     '<label>';
  switch(LOGIN_METHOD)
  {
   case 'both':
    $htmlForm .= $ACL_LANG['USERNAME'].'/'.$ACL_LANG['EMAIL'];
    break;
   case 'email':
    $htmlForm .= $ACL_LANG['EMAIL'];
    break;
   default:
    $htmlForm .= $ACL_LANG['USERNAME'];
    break;
  }      
  $htmlForm .= ':</label>'.
      '<input type="text" name="u" id="u" class="textfield" />'.
      '<label>'.$ACL_LANG['PASSWORD'].'</label>'.
      '<input type="password" name="p" id="p" class="textfield" />'.
      '<center><input type="submit" name="btn" id="btn" class="buttonfield" value="Sign in to extranet" /></center>'.
      '</form>';
  return $htmlForm;

The problem is, is that when the user hits enter in IE8, the form does not submit, and the user is forced to hit the submit button.

How do I rectify this?

Thanks, ct2k7

+2  A: 

If this is a real problem and you can't find another solution you can always do an onkeypress event for the form and check if the enter key was pressed.

EDIT: Here's the correct code according to Machine's answer:

$htmlForm .= ':<form><label>'.$ACL_LANG['USERNAME'].'</label>'.
                                     '<input type="text" name="u" id="u" class="textfield" />'.
                                     '<label>'.$ACL_LANG['PASSWORD'].'</label>'.
                                     '<input type="password" name="p" id="p" class="textfield" />'.
                                     '<center><input type="submit" name="btn" id="btn" class="buttonfield" value="Sign in to extranet" /></center>'.
                                     '</form>';

EDIT 2: Your HTML is valid. Try this:

function checkEnter(e){ //e is event object passed from function invocation
var characterCode literal character code will be stored in this variable

if(e && e.which){ //if which property of event object is supported (NN4)
e = e
characterCode = e.which //character code is contained in NN4's which property
}
else{
e = event
characterCode = e.keyCode //character code is contained in IE's keyCode property
}

if(characterCode == 13){ //if generated character code is equal to ascii 13 (if enter key)
document.forms[0].submit() //submit the form
return false
}
else{
return true
}

}
the_drow
type in first row .is: <labl>should be: <label>
Michal M
fixed. thanks :)
the_drow
Could you just revise the code from the full piece of code for that section to which I've added the full code?
Shamil
It seems that your html is valid.Take a look at the answer now.
the_drow
+3  A: 

Do you have an opening form tag that was just omitted from your code snippet?

PatrikAkerstrand
It was ommited from the code snippet
Shamil
+1  A: 

The action attribute on the form element is required by the HTML spec. Maybe it'll work better.

Alsciende
the portion was ommitted in the code snippet.
Shamil
+4  A: 

Here is a link in Microsoft on it which might shed some light for you.

Taking a quick read of the link it might actually be considered a bug submitting the form by the Enter Key, which I presume would of been fixed by Microsoft for IE8.

IE anomaly when using the enter key to submit a form

Edit:

This has now been removed but another link covering it again (bottom of page) which defined it and explaining the bug in IE Blog on December 18th 2008.

kevchadders
Link didn't work for me.
Lucas Richter
Good spot its now been removed. I've managed to find some other links which reference it but as its been resolved they have removed it.
kevchadders
+1  A: 

I was able to reproduce this as well with an action and method. Stripped out all other code on the page and it still gets produced. However, I have seen forms work in IE8 with action=""

David
+2  A: 

Also watch out for this fun fun bug:

I've learned the hard way that if your form is display:none at page load, even if you show it later with Javascript, IE8 still won't submit on enter. However, if it's not hidden at page load, and you set it to display:none after, like onDOMReady, then it works! WTF

Infinity
:eek This is good to play with :D
Shamil