views:

1029

answers:

5

Let's presume that I have string like '=&?/;#+%' to be a part of my URL, let's say like this:

example.com/servletPath/someOtherPath/myString/something.html?a=b&c=d#asdf

where myString is the above string. I've encoded critical part so URL looks like

example.com/servletPath/someOtherPath/%3D%26%3F%2F%3B%23%2B%25/something.html?a=b&c=d#asdf

So far so good.

When I'm in the servlet and I read any of request.getRequestURI(), request.getRequestURL() or request.getPathInfo(), returned value is already decoded, so I get strilng like

someOtherPath/=&?/;#+%/something.html?a=b&c=d#asdf

and I can't differentiate between real special characters and encoded ones.

I've solved particular problem by banning above chars altogether, which works in this situation, but I still wonder is there any way to get undecoded URL in servlet class.

YET ANOTHER EDIT: When I've hit this problem last evening I was too tired to notice what is really going on, which is even more bizarre! I have servlet mapped on, say /servletPath/* after that I can put whatever I want and get my servlet responding depending on the rest of a path, except when there is %2F in the path. In that case request never hits the servlet, and I get 404! If i put '/' instead of %2F it works OK. I'm running Tomcat 6.0.14 on Java 1.6.0-04 on Linux.

A: 

If there's a %2F in the decoded url, it means the encoded url contained %252F.

Since %2F is / Why not just split on "\/" and not worry about URL encoding?

R. Bemrose
A: 

It seems like you are trying to do something RESTy (use Jersey). Can's you just parse off the leading and trailing parts of the URL to get the data you are looking for?

url.substring(startLength, url.length - endLength);

stevedbrown
nope, I've got param1/param2/param3 and they are all of unknown length.
Slartibartfast
+1  A: 

According to the Javadoc, getRequestURI should not decode the string. On the other hand, getServletPath return a decoded string. I tested this locally using Jetty and it behaves as described in the doc.

So there might be something else at play in your situation since the behavior you're describing doesn't match the Sun documentation.

Francois Gravel
You are partially right. When I have some UTF-8 character it stays undecoded, but spetial characters arent. I'm working on Tomcat.
Slartibartfast
A: 

You should not have to make a difference between an encoded and not encoded character in the path part of the URL. There is no character inside the path that can have a special meaning in a URL. E.g. '%2F' must be interpreted the same as '/', and a browser accessing such a URL is free to replace one by the other as it sees fit. Making a difference between them is breaking the standard of how URLs are encoded.

In the complete URL, you do want to make a difference:

  • To see where the path part ends. Because a ? encoded in the path should not be seen as the end.
  • Inside the query String. Because part of the value of a parameter could contain '&' or '=',...

But Java already deals fine with that. You can use:

  • getPathInfo() which returns only the path part, decoded (the encoding must not matter anyways)
  • getParameter(String) to access parts of the query part

Now, if you really want to do your own parsing of the URL, you can use

  • getQueryString() which returns the query part, not decoded, so you can parse that yourself
  • if you want to go further and do the splitting of path and query too: getRequestURI() which gives you the full URL, not decoded. If that one gives the URL decoded as you claim, then that means there is a bug in the servlet implementation you're using.
Wouter Coekaerts
So it was my bad that I've thought that there is difference between / and %2F, while by standard there isn't. As I've said, I've skip the problem by eliminating characters before they hit url encoding part, which is I guess only standard compilant way.
Slartibartfast
+3  A: 

The first answer by Wouter Coekaerts is wrong, and R. Bemrose reiterates his mistake. There is a fundamental difference between '%2F' and '/', both for the browser and the server.

The HttpServletRequest specification says (without any logic, AFAICT):

  • getContextPath: not decoded
  • getPathInfo: decoded
  • getPathTranslated: not decoded
  • getQueryString: not decoded
  • getRequestURI: not decoded
  • getServletPath: decoded

The result of getPathInfo() should be decoded, but the result of getRequestURI() must not be decoded. If it is, your Servlet container is breaking the spec (as Wouter Coekaerts and Francois Gravel correctly pointed out). Which Tomcat version are you running?

Making matters even more confusing, current Tomcat versions reject paths that contain encodings of certain special characters, for security reasons.

Christopher Sahnwaldt