critique

Please critique my class

Hi all I've taken a few school classes along time ago on and to be honest i never really understood the concept of classes. I recently "got back on the horse" and have been trying to find some real world application for creating a class. you may have seen that I'm trying to parse a lot of family tree data that is in an very old and ant...

Python Critique

Hi, I'm using Python now for about two months, and to be honest, it really made me love programming again. After programming in C, Java, and worst of all, C++, Python is incredibly fun. Thinking that I approach such language with all positive bias, I would love to hear some critique of Python language. Beside its extremely rich library,...

I need some critique about lib design

OK. I have this lib for my internal project (function() { var window = this, undefined; //guaranteed undefined var h3 = window.h3 = function (user) { return window.h3 = new h3.prototype.init(user); }; h3.prototype = { init: function(user) { this.timestamp = +new Date; this.user = use...

Where would I find critiques for my source code?

Well the most obvious answer is here. Self taught programming has some down sides, one of which is the lack of code peer critique which can help one expand his/her programming scope. Since I'm working by myself, what would be a great way for me to get some critique on all of my source code (like a really long source code)? ...

Critiquing my first Python script

A little bit of background: I'm building an inverted index for a search engine. I was originally using PHP, but because of the amount of times I needed to write to disk, I wanted to make a threaded indexer. There's a problem with that because PHP is not thread safe. I then tried Java, but I ended up with at least 20 try catch blocks bec...

What are the best places on the web to present my application for critique and suggestions?

I pretty much suppose that if I issue a question here on StackOverflow, saying "hey, colleagues, go this link to my website, download my CoolProggie and write a line on what you think?" it is going to be considered a sort of advertisement, downvoted and closed. Can you suggest any correct places for this, where I am going to find enough ...

Scala n00b: Critique my code

G'day everyone, I'm a Scala n00b (but am experienced with other languages) and am learning the language as I find time - very much enjoying it so far! Usually when learning a new language the first thing I do is implement Conway's Game of Life, since it's just complex enough to give a good sense of the language, but small enough in sco...

Critique my concurrent queue

This is a concurrent queue I wrote which I plan on using in a thread pool I'm writing. I'm wondering if there are any performance improvements I could make. atomic_counter is pasted below if you're curious! #ifndef NS_CONCURRENT_QUEUE_HPP_INCLUDED #define NS_CONCURRENT_QUEUE_HPP_INCLUDED #include <ns/atomic_counter.hpp> #include <boost...

Critique my prime_factors() function

I just wrote this function to break a number into its prime factors. Is the algorithm I'm using a good one? How might I improve this function? So far it seems to be working quite well. from copy import copy # Decorator to memoize using the first argument only @memoize_first def prime_factors(n, prime_list=[None], prime_limit=[None]): ...

Ruby Code Critique

I'm a Ruby newbie (started 4 days ago and hey it rhymes!) and decided to code a simple little tool for fun/learning. The following code was the result. It works fine, but I would really appreciate critique from some more experienced Ruby developers. I'm looking for comments on style, verbosity, and any misc. tips/tricks. By the way, I'm...

What pitfalls does this Perl code have?

I have written some code to print formatted arrays (first line = no of inputs, second line = max width of numbers). The star can be any sort of marker to differentiate some elements from the rest. $ cat inp.txt 6 2 1 * 2 3 4 9 12 * $ cat inp.txt | ./formatmyarray.pl ____ ____ ____ ____ ____ ____ | * | | | | | * | | 1 | ...

Can you critique my solution for the "ring benchmark" problem from J. Armstrong's book?

I am making my way through Joe Armstrong's book on programing Erlang. I came up with the following answer for the ring benchmark question. The code works but I am not sure if it is "Erlangic" (for lack of a better word). In particular I am not sure if I am using too many Guards. Can more experienced programmers critique the code? I had...