views:

734

answers:

5

ok, i need my code to check if minus/subtract/- was pressed, if it was pressed i want an alert box to pop. i tried with both 109 and 189 key codes but i still don't get the desired result. although i press "-" i don't get that alert box

+1  A: 

The JavaScript charCodes, which you test for during a keypress event, are ASCII. 109 is the correct keyCode, if used in a keydown or keyup event.

"-" has a charCode of 45.

Dave Ward
thanks, where can i find a complete list of the javascript keycodes? i found one or two but there i found "-" as 109 and 189
kmunky
http://www.cambiaresearch.com/c4/702b8cd1-e5b0-42e6-83ac-25f0306e3e25/Javascript-Char-Codes-Key-Codes.aspx
Matt
ok, i fount a good one :P http://forums.devarticles.com/javascript-development-22/very-helpful-key-codes-list-72985.html
kmunky
The ASCII link in my answer has a list of codes.
Dave Ward
Why worry about the actual value of the character code? Why not just convert it to a string using `String.fromCharCode`?
Tim Down
Because it's quite a bit faster.
Dave Ward
Fair enough, although unless you have loads of keypress event handlers I think it's unlikely to make much of a difference.
Tim Down
It's one of those things that may be premature optimization, but why knowingly degrade the performance of a heavily called function if you don't have to. If readability is an issue, you can always comment it without impacting performance.
Dave Ward
+3  A: 

Post some code. This works for me:

document.onkeydown = function (e) {
 if (e.keyCode === 109 || e.keyCode === 189) {
  alert('minus sign pressed');
 }
};

Full list of key codes here: http://www.cambiaresearch.com/c4/702b8cd1-e5b0-42e6-83ac-25f0306e3e25/Javascript-Char-Codes-Key-Codes.aspx

Matt
Don't do this in the `keydown` event. See my answer.
Tim Down
+3  A: 

You can discover keyCodes this way:

Rubens Farias
+2  A: 

I hope this works for you, It detects users pressed keys and if it's the one your looking for it displays the alert, you may change the actual key to be any other key.

function detectSubstract(e)
{
var evtobj=window.event? event : e //distinguish between IE's explicit event object (window.event) and Firefox's implicit.
var unicode=evtobj.charCode? evtobj.charCode : evtobj.keyCode
var actualkey=String.fromCharCode(unicode)

    if (actualkey=="-")
    {
        alert('You pressed the minus key')
    }
}
document.onkeypress=detectSubstract
johnnyArt
A: 

Don't do this in a keydown event handler - you put yourself at the mercy of different browsers' ideas about key codes and potential variation between key codes for different keyboard types. Do it in a keypress event and then you can get the character code instead, which is what you actually want.

document.onkeypress = function(evt) {
    evt = evt || window.event;
    var charCode = evt.which || evt.keyCode;
    var charStr = String.fromCharCode(charCode);
    if (charStr == "-") {
        alert("Minus!");
    }
};
Tim Down
Actually `keydown` is a better answer than `keypress`. If you look at the compatibility list (http://www.quirksmode.org/js/keys.html) `keypress` didn't work in some older versions of Firefox
fudgey
@fudgey: I think you're misreading those compatibility tables. The `charCode` and `which` properties of the `keypress` event have been happily reporting character codes correctly in Firefox since I first tried it, which I think was pre-1.0. What you may be picking out from those tables is that Firefox always reports 0 for the `keyCode` property of `keypress` events, which really isn't a problem here.
Tim Down