views:

1388

answers:

1

Good people:

is there a way to express that my Spring Web MVC controller method should be matched either by a request handing in a ID as part of the URI path ...

@RequestMapping(method=RequestMethod.GET, value="campaigns/{id}")
public String getCampaignDetails(Model model, @PathVariable("id") Long id) {

... or if the client sends in the ID as a HTTP request parameter in the style ...

@RequestMapping(method=RequestMethod.GET, value="campaigns")
public String getCampaignDetails(Model model, @RequestParam("id") Long id) {

This seems to me a quite common real-world URL scheme where I don't want to add duplicate code, but I wasn't able to find an answer yet. Any advice highly welcome.

EDIT: It turns out that there seems currently (with Spring MVC <= 3.0) no way to achieve this, see discussion inside Javi's answer.

+1  A: 

You can set both mapping url for the same function and setting id as optional.

@RequestMapping(method=RequestMethod.GET, value={"/campaigns","/campaigns/{id}"})
public String getCampaignDetails(Model model, @RequestParam(value="id", required=false) Long id, @PathVariable("id") Long id2) {
}

though it would map as well when id is not sent, but you can control this inside the method.

EDIT: The previous solution doesn't work because @PathVariable is not set to null when there isn't {null} and it cannot map the url (thanks ngeek). I think then that the only posible solution is to create two methods each one mapped with its @MappingRequest and inside one of them call the other function or redirect to the other URL (redirect: or forward: Spring prefixes). I know this solution is not what you're looking for but think it's the best you can do. Indeed you're not dupplicating code but you're creating another function to handle another url.

Javi
Unfortunately this is not working, since the path variable cannot be resolved. I also tried a variant by adding to the method parameters (@PathVariable("id") Long id2) but then you cannot make a path variable optional, therefore this proposed solution does not work.Any more recommendations?
ngeek
@ngeek I didn't realize that @PathVariable couldn't be set to null, thanks. I had also forget to write @PathVariable so I've edited my answer to add it and I think you cannot avoid to have 2 methods I think :(.
Javi
Thanks for coming back to your proposal Javi. Sure thing I was already delegating to the same internal method to avoid to duplicate code. I still think that Spring MVC annotations should provide a mean to map multiple URL defintions to the same method by intrinsic mean, like routers in Rails or Grails do already allow.Thanks for your help anyway.
ngeek