Using "this" in front of member variables in C++

Question

Possible Duplicates:
Is excessive use of this in C++ a code smell

Given that most organizations have a coding standard for member variables like "m_memberVar" or "memberVar_", are there good reasons to use "this->memberVal" format instead?

Is there any reason not to?

Answer 1

The main reason not to include 'this' everywhere is simply to avoid clutter. An access to a variable that's NOT a member variable should be rare in a good object-oriented design.

Answer 2

Technically I don't think there is any drawback. What is more important, like with any coding style - is that all developers need to follow it. It is really messy when there is a mixture of m_memberVar, memberVar_ and this-> in the code.

Answer 3

I think it is a much more better looking choice then having a _ in front of every variable. But with having a good IDE none of the both choices are needed any and should only be used to make something more clear.

Answer 4

In my experiences, I typically use the "this" keyword for variables in constructors and setters. It cleans up the assignment of arguments, for example:

MyClass(int x) {
  this.x = x;
}

Just be careful not to do something like

MyClass(int x) {
  x = x;
}

as this assignment will have no effect. However, finalizing the x member variable will prevent this from happening (and most IDEs will tell you the assignment does nothing).

Most importantly (as another person also stated), consistency is important. Code written by one developer in your organization should look the same as code written by the other developers.

Answer 5

I think is bad to use this->.
The code this->aMemberVariable and aMemberVariable is server same access in a object.
Use of this-> only adds more coding (typing) and makes the code look messy.

Answer 6

I think using `this' keyword in C++ is a waste of space considering the language doesn't force you to do it and the fact that its almost never necessary, except maybe in constructors. If you can't keep track of the variables in a class, then the class is too big.