Linker error while compiling C++ code

Question

Hello,

First of all, excuse me for my poor knowledge on C++. I am a real Beginner!

I am trying to compile one C++ code on MS VS2005. I am getting a linker error as follows for below piece of code:-

In one function(some class method) definition, it has code for memory allocation like:

CDecoderUnit *du = new CDecoderUnit(); //<<error is shown at this line

This CDecoderUnit is a class defined in a header file as something like

class CDecoderUnit : public IPrepareDecoderUnit
{
   CDecoderUnit();
   ~CDecoderUnit();
...
...
other class definition.

..
..
}

The actual error is:-

Error 9 error LNK2019: unresolved external symbol "public: __thiscall CDecoderUnit::CDecoderUnit(void)" (??0CDecoderUnit@@QAE@XZ) referenced in function "private: long __thiscall CLSDEnc::CreateIPrepareDecoderUnit(struct IPrepareDecoderUnit * &)const " (?CreateIPrepareDecoderUnit@CLSDEnc@@ABEJAAPAUIPrepareDecoderUnit@@@Z) lsdenc.obj

Can anyone point me to resolve this? Is any more info needed?

Thank you.

-AD.

Answer 1

The default accessibility in a class is private. Declare your constructor like this:

public: CDecoderUnit();

Answer 2

Possible problems:

• You didn't define the constructer in the .cpp
• You didn't include the right header in your .cpp
• You forgot to make the constructor public (class methods are private by default)

Try to:

• Rebuild the project
• Check that you include the right header in the .cpp (spelling! ;) )
• Remember that your constructor should go like this: CDecoderUnit::CDecoderUnit(){} in the .cpp
• Add public: to the top of your class definition in the .h (Remember to do private: for your privates)
• You forgot the ; after the class definition (Don't think this is it. The compiler ussually generates a different error for this)

To make your constructor public, declare the class like this:

class MyClass
{
public:
   //Public stuff goes here
   MyClass();
   void publicMethod();
private:
   //Private stuff goes here
};

Answer 3

When you write CDecoderUnit(); you are doing 2 things:

• Declaring a default constructor (not implementing it, just declaring it).
• Causing the compiler not to generate a default constructor on its own.

You need to either define the constructor if it needs to initialize anything, or remove the declaration which will let the compiler generate one itself. Note that if you do implement the constructor, you'll have to make it public if you want to create objects from outside the class.

Answer 4

Do you have the source file containing the method bodies for methods such as CDecoderUnit::CDecoderUnit() included in your project?

If so, check the properties on that source file to make sure that it is actually being used - right-click in the Solution Explorer to choose properties and check the General property Excluded from Build is set to No.

A more subtle problem can arise with line endings. The editor understands different line ending styles and will correctly show your file. The compiler only understands the Windows (CR LF) style. If the first line is a // comment then the compiler sees the entire file as being commented out. In this case, the fix is to save it as Windows style - see File - Advanced Save Options.

Answer 5

Are these two things in two different dlls ? For example, if you have defined CDecoderUnit in one dll and creating an instance in another one. If that is the case, then you have to export the class from the first dll so as to create the object in the other one.

Answer 6

Tal Pressman is right.