views:

995

answers:

3

Option monad is a great expressive way to deal with something-or-nothing things in Scala. But what if one needs to log a message when "nothing" occurs? According to the Scala API documentation,

The Either type is often used as an alternative to scala.Option where Left represents failure (by convention) and Right is akin to Some.

However, I had no luck to find best practices using Either or good real-world examples involving Either for processing failures. Finally I've come up with the following code for my own project:

    def logs: Array[String] = {
        def props: Option[Map[String, Any]] = configAdmin.map{ ca =>
            val config = ca.getConfiguration(PID, null)
            config.properties getOrElse immutable.Map.empty
        }
        def checkType(any: Any): Option[Array[String]] = any match {
            case a: Array[String] => Some(a)
            case _ => None
        }
        def lookup: Either[(Symbol, String), Array[String]] =
            for {val properties <- props.toRight('warning -> "ConfigurationAdmin service not bound").right
                 val logsParam <- properties.get("logs").toRight('debug -> "'logs' not defined in the configuration").right
                 val array <- checkType(logsParam).toRight('warning -> "unknown type of 'logs' confguration parameter").right}
            yield array

        lookup.fold(failure => { failure match {
            case ('warning, msg) => log(LogService.WARNING, msg)
            case ('debug, msg) =>   log(LogService.DEBUG, msg)
            case _ =>
        }; new Array[String](0) }, success => success)
    }

(Please note this is a snippet from a real project, so it will not compile on its own)

I'd be grateful to know how you are using Either in your code and/or better ideas on refactoring the above code.

+6  A: 

Either is used to return one of possible two meaningful results, unlike Option which is used to return a single meaningful result or nothing.

A easy to understand example is given below (circulated on the Scala mailing list a while back):

def throwableToLeft[T](block: => T): Either[java.lang.Throwable, T] =
  try {
    Right(block)
  } catch {
    case ex => Left(ex)
  }

As the function name implies, if the execution of "block" is successful, it will return "Right(<result>)" else, if an Throwable is thrown, it will return "Left(<throwable>)". Use pattern matching to process the result:

var s = "hello"
throwableToLeft { s.toUpperCase } match {
  case Right(s) => println(s)
  case Left(e) => e.printStackTrace
}
// prints "HELLO"

s = null
throwableToLeft { s.toUpperCase } match {
  case Right(s) => println(s)
  case Left(e) => e.printStackTrace
}
// prints NullPointerException stack trace

Hope that helps.

Walter Chang
Peculiar... why not just throw the exception?
skaffman
Having exception handling code all over the place is ugly and hard to manage. Use throwableToLeft turns exception handling into pattern matching which, imho, easier to read and maintain.
Walter Chang
For example, you may have several actors doing different calculations concurrently, some of which actually return a result, and some throw an exception. If you just throw the exception, some of those actors may not have started working yet, you lose results from any actors who haven't finished yet, etc. With this approach, all actors will return a value (some `Left`, some `Right`) and it ends up being much easier to handle.
Alexey Romanov
+2  A: 

The snippet you posted seems very contrived. You use Either in a situation where:

  1. It's not enough to just know the data isn't available.
  2. You need to return one of two distinct types.

Turning an exception into a Left is, indeed, a common use case. Over try/catch, it has the advantage of keeping the code together, which makes sense if the exception is an expected result. The most common way of handling Either is pattern matching:

result match {
  case Right(res) => ...
  case Left(res) => ...
}

Another interesting way of handling Either is when it appears in a collection. When doing a map over a collection, throwing an exception might not be viable, and you may want to return some information other than "not possible". Using an Either enables you to do that without overburdening the algorithm:

val list = (
  library 
  \\ "books" 
  map (book => 
    if (book \ "author" isEmpty) 
      Left(book) 
    else 
      Right((book \ "author" toList) map (_ text))
  )
)

Here we get a list of all authors in the library, plus a list of books without an author. So we can then further process it accordingly:

val authorCount = (
  (Map[String,Int]() /: (list filter (_ isRight) map (_.right.get))) 
   ((map, author) => map + (author -> (map.getOrElse(author, 0) + 1)))
  toList
)
val problemBooks = list flatMap (_.left.toSeq) // thanks to Azarov for this variation

So, basic Either usage goes like that. It's not a particularly useful class, but if it were you'd have seen it before. On the other hand, it's not useless either.

Daniel
list flatMap {_.left.toSeq} seems to return the same problemBooks, right?
Alexander Azarov
Yes, it would. I knew there was a flatMap trick to it, but I couldn't find it when I wrote the example.
Daniel
+2  A: 

You might find this useful ...

Miles Sabin
Miles, thank you. The idea behind your code is very similar to Box concept from Liftweb. The extra feature they have is ability to chain Failures though
Alexander Azarov
It's main advantage over Box is that it's expressed in terms of Option and Either. I'm not quite sure what you main by "chain Failures" can you give me an example?
Miles Sabin
(Empty ?~! "error") ?~! "error2" must_== Failure("error2", Empty, Full(Failure("error", Empty, Empty)))
Alexander Azarov