views:

834

answers:

7

If I have a list of dictionaries, say:

[{'id': 1, 'name': 'paul'},
{'id': 2, 'name': 'john'}]

and I would like to remove the dictionary with id of 2 (or name john), what is the most efficient way to go about this programmatically (that is to say, I don't know the index of the entry in the list so it can't simply be popped).

+1  A: 

list.pop() is a good choice:

>>> a = [{'id': 1, 'name': 'paul'},
... {'id': 2, 'name': 'john'}]
>>> a.pop(1)
{'id': 2, 'name': 'john'}
>>> a
[{'id': 1, 'name': 'paul'}]

You can develop other ways of tracking done which dictionary you want to eliminate, so long as it resolves to an integer. Here is one of those ways:

>>> a = [{'id': 1, 'name': 'paul'},
... {'id': 2, 'name': 'john'}]
>>> for i in reversed(range(len(a))):
...     if a[i].get('id') == 2:
...             a.pop(i)
...
{'id': 2, 'name': 'john'}
>>> a
[{'id': 1, 'name': 'paul'}]

Another possibility is to use del:

[{'id': 1, 'name': 'paul'}]
>>> a = [{'id': 1, 'name': 'paul'},
... {'id': 2, 'name': 'john'}]
>>> a
[{'id': 1, 'name': 'paul'}, {'id': 2, 'name': 'john'}]
>>> del a[1]
>>> a
[{'id': 1, 'name': 'paul'}]
hughdbrown
+15  A: 
thelist[:] = [d for d in thelist if d.get('id') != 2]

Edit: as some doubts have been expressed in a comment about the performance of this code (some based on misunderstanding Python's performance characteristics, some on assuming beyond the given specs that there is exactly one dict in the list with a value of 2 for key 'id'), I wish to offer reassurance on this point.

On an old Linux box, measuring this code:

$ python -mtimeit -s"lod=[{'id':i, 'name':'nam%s'%i} for i in range(99)]; import random" "thelist=list(lod); random.shuffle(thelist); thelist[:] = [d for d in thelist if d.get('id') != 2]"
10000 loops, best of 3: 82.3 usec per loop

of which about 57 microseconds for the random.shuffle (needed to ensure that the element to remove is not ALWAYS at the same spot;-) and 0.65 microseconds for the initial copy (whoever worries about performance impact of shallow copies of Python lists is most obviously out to lunch;-), needed to avoid altering the original list in the loop (so each leg of the loop does have something to delete;-).

When it is known that there is exactly one item to remove, it's possible to locate and remove it even more expeditiously:

$ python -mtimeit -s"lod=[{'id':i, 'name':'nam%s'%i} for i in range(99)]; import random" "thelist=list(lod); random.shuffle(thelist); where=(i for i,d in enumerate(thelist) if d.get('id')==2).next(); del thelist[where]"
10000 loops, best of 3: 72.8 usec per loop

(use the next builtin rather than the .next method if you're on Python 2.6 or better, of course) -- but this code breaks down if the number of dicts that satisfy the removal condition is not exactly one. Generalizing this, we have:

$ python -mtimeit -s"lod=[{'id':i, 'name':'nam%s'%i} for i in range(33)]*3; import random" "thelist=list(lod); where=[i for i,d in enumerate(thelist) if d.get('id')==2]; where.reverse()" "for i in where: del thelist[i]"
10000 loops, best of 3: 23.7 usec per loop

where the shuffling can be removed because there are already three equispaced dicts to remove, as we know. And the listcomp, unchanged, fares well:

$ python -mtimeit -s"lod=[{'id':i, 'name':'nam%s'%i} for i in range(33)]*3; import random" "thelist=list(lod); thelist[:] = [d for d in thelist if d.get('id') != 2]"
10000 loops, best of 3: 23.8 usec per loop

totally neck and neck, with even just 3 elements of 99 to be removed. With longer lists and more repetitions, this holds even more of course:

$ python -mtimeit -s"lod=[{'id':i, 'name':'nam%s'%i} for i in range(33)]*133; import random" "thelist=list(lod); where=[i for i,d in enumerate(thelist) if d.get('id')==2]; where.reverse()" "for i in where: del thelist[i]"
1000 loops, best of 3: 1.11 msec per loop
$ python -mtimeit -s"lod=[{'id':i, 'name':'nam%s'%i} for i in range(33)]*133; import random" "thelist=list(lod); thelist[:] = [d for d in thelist if d.get('id') != 2]"
1000 loops, best of 3: 998 usec per loop

All in all, it's obviously not worth deploying the subtlety of making and reversing the list of indices to remove, vs the perfectly simple and obvious list comprehension, to possibly gain 100 nanoseconds in one small case -- and lose 113 microseconds in a larger one;-). Avoiding or criticizing simple, straightforward, and perfectly performance-adequate solutions (like list comprehensions for this general class of "remove some items from a list" problems) is a particularly nasty example of Knuth's and Hoare's well-known thesis that "premature optimization is the root of all evil in programming"!-)

Alex Martelli
Two reasons why this is bad: it copies the entire list, and it traverses the entire list even if the dictionary containing id 2 is the very first element.
Imagist
@imagist, it's nevertheless fastest -- MEASURE it, for goodness sake, don't just ASSUME you know what you're talking about, esp. when you obviously don't;-), *ESPECIALLY* when the item to remove is the first (it avoids moving every other item). And there's no indication in the original question that every dict in the list MUST always have a different value corresponding to 'id'.
Alex Martelli
Hmmmm. Not bad. There are two approaches: make a new list with some elements filtered out or modify the existing list to remove some elements. This is just the former approach. And as far as that goes, there is nothing to say that a dictionary with id=2 won't appear more than once in the list. It's a list -- there is no guarantee of uniqueness. And the OP did not suggest this limitation.
hughdbrown
@Alex, exactly - I love list comprehensions for their sheer blinding speed. And, since as of Python 3 `filter` will return an iterator, this should be standard practice.
Meredith L. Patterson
@hughdbrown and @Meredith, I've now added copious measurements and variants showing performance behavior in various cases -- hope it's as interesting to read as it was to code and measure;-)
Alex Martelli
What is the colon for in `theList[:]`?
kzh
@kzh: `theList[:]` is equivalent to `theList[0:len(theList)]`. In this context, it means "change theList in-place".
John Fouhy
What is the difference between `theList[:] = ..` and `theList = ..`?
kaizer.se
A: 

You can try the following:

a = [{'id': 1, 'name': 'paul'},
     {'id': 2, 'name': 'john'}]

for e in range(len(a) - 1, -1, -1):
    if a[e]['id'] == 2:
        a.pop(e)

If You can't pop from the beginning - pop from the end, it won't ruin the for loop.

zeroDivisible
You mean "range(len(a) - 1, -1, -1)", not "range(len(a) - 1, 0, -1)". This does not include the first element of the list. I've heard word that reversed() is preferred nowadays. See my code below.
hughdbrown
Here's what I was getting at:>>> a = list(range(5))>>> a[0, 1, 2, 3, 4]>>> range(len(a) - 1, -1, -1)[4, 3, 2, 1, 0]>>> range(len(a) - 1, 0, -1)[4, 3, 2, 1]Just wait for the comment-mangling...
hughdbrown
+1  A: 

Here's a way to do it with a list comprehension (assuming you name your list 'foo'):

[x for x in foo if not (2 == x.get('id'))]

Substitute 'john' == x.get('name') or whatever as appropriate.

filter also works:

foo.filter(lambda x: x.get('id')!=2, foo)

And if you want a generator you can use itertools:

itertools.ifilter(lambda x: x.get('id')!=2, foo)

However, as of Python 3, filter will return an iterator anyway, so the list comprehension is really the best choice, as Alex suggested.

Meredith L. Patterson
also, .get is better than [] here, as it doesn't break if some dict in the list does NOT have an entry for key 'id'.
Alex Martelli
Good suggestion - edited answer accordingly.
Meredith L. Patterson
A: 

You could try something along the following lines:

def destructively_remove_if(predicate, list):
      for k in xrange(len(list)):
          if predicate(list[k]):
              del list[k]
              break
      return list

  list = [
      { 'id': 1, 'name': 'John' },
      { 'id': 2, 'name': 'Karl' },
      { 'id': 3, 'name': 'Desdemona' } 
  ]

  print "Before:", list
  destructively_remove_if(lambda p: p["id"] == 2, list)
  print "After:", list

Unless you build something akin to an index over your data, I don't think that you can do better than doing a brute-force "table scan" over the entire list. If your data is sorted by the key you are using, you might be able to employ the bisect module to find the object you are looking for somewhat faster.

Dirk
+3  A: 

This is not properly an anwser (as I think you already have some quite good of them), but... have you considered of having a dictionary of <id>:<name> instead of a list of dictionaries?

fortran
+1: "If it's hard, you're doing it wrong." If you want to remove things by an attribute, use a dictionary, keyed by the attribute. Much simpler.
S.Lott
...as long as you don't care at all about preserving the order of items, never want to remove things by a different attribute, are happy with never allowing any duplicates regarding that one attribute, etc, etc -- far too many restrictions above and beyond any specs expressed by the OP, to make this suggestion reasonable;-).
Alex Martelli
If I'd had to take all those specs for granted, I would have said "use a database" xD
fortran
A: 
# assume ls contains your list
for i in range(len(ls)):
    if ls[i]['id'] == 2:
        del ls[i]
        break

Will probably be faster than the list comprehension methods on average because it doesn't traverse the whole list if it finds the item in question early on.

Imagist
will raise `KeyError` if dict has no `id`. and that's not what OP asked for.
SilentGhost