tags:

views:

1048

answers:

5

This question is basically the second half to my other Question

How can I convert a UINT16 value, into a UINT8 * array without a loop and avoiding endian problems.

Basically I want to do something like this:

UINT16 value = 0xAAFF;
UINT8 array[2] = value;

The end result of this is to store value into a UINT8 array while avoiding endian conversion.

UINT8 * mArray;
memcpy(&mArray[someOffset],&array,2);

When I simply do memcpy with the UINT16 value, it converts to little-endian which ruins the output. I am trying to avoid using endian conversion functions, but think I may just be out of luck.

A: 

A temporary cast to UINT16* should do it:

((UINT16*)array)[0] = value;
RightFullRudder
This doesn't work because it's still sensitive to endianness (basically, it does the same thing as the `memcpy` in the question).
Martin B
+4  A: 

There's no need for conditional compilation. You can bit-shift to get the higher and lower byte of the value:

uint16_t value = 0xAAFF;
uint8_t hi_lo[] = { (uint8_t)(value >> 8), (uint8_t)value }; // { 0xAA, 0xFF }
uint8_t lo_hi[] = { (uint8_t)value, (uint8_t)(value >> 8) }; // { 0xFF, 0xAA }

The casts are optional.

Christoph
question tag is c++, use c++ casts.
fnieto
+5  A: 

How about

UINT16 value = 0xAAFF;
UINT8 array[2];
array[0]=value & 0xff;
array[1]=(value >> 8);

This should deliver the same result independent of endianness.

Or, if you want to use an array initializer:

UINT8 array[2]={ value & 0xff, value >> 8 };

(However, this is only possible if value is a constant.)

Martin B
+1  A: 

Assuming that you want to have the high-order byte above the lower-order byte in the array:

array[0] = value & 0xff;
array[1] = (value >> 8) & 0xff;
Jonathan
the mask `0xff` is unnecessary: the conversion from 16 to 8 bit integers will drop the higher byte (unsigned conversion is well-defined!)
Christoph
That's true, but I generally mask everything for clarity. Sometimes, I'll even do a bit-shift by 0 so that the lines all match up and look good vertically. Any good compiler will optimize out the unnecessary statements, and it is well worth the clarity.
Jonathan
A: 
union TwoBytes
{
    UINT16 u16;
    UINT8 u8[2];
};

TwoBytes Converter;
Converter.u16 = 65535;
UINT8 *array = Converter.u8;
Niki Yoshiuchi
This is sensitive to endianness.
Jonathan