views:

1272

answers:

7

I'm attempting to create a PDF file from an HTML file. After looking around a little I've found: wkhtmltopdf to be perfect. I need to call this .exe from the ASP.NET server. I've attempted:

    Process p = new Process();
    p.StartInfo.UseShellExecute = false;
    p.StartInfo.FileName = HttpContext.Current.Server.MapPath("wkhtmltopdf.exe");
    p.StartInfo.Arguments = "TestPDF.htm TestPDF.pdf";
    p.Start();
    p.WaitForExit();

With no success of any files being created on the server. Can anyone give me a pointer in the right direction? I put the wkhtmltopdf.exe file at the top level directory of the site. Is there anywhere else it should be held?

Thanks.


Edit: If anyone has better solutions to dynamically create pdf files from html, please let me know.

A: 

The ASP .Net process probably doesn't have write access to the directory.

Try telling it to write to %TEMP%, and see if it works.

Also, make your ASP .Net page echo the process's stdout and stderr, and check for error messages.

SLaks
Not sure, wasn't me. Thanks for the info though, will test it out. Seems I should go about a different way to create pdf files from html though.
Sean
there are .NET wrappers for it, http://csharp-source.net/open-source/pdf-libraries came from a quick google search
Yuriy Faktorovich
+3  A: 

There are many reason why this is generally a bad idea. How are you going to control the executables that get spawned off but end up living on in memory if there is a crash? What about denial-of-service attacks, or if something malicious gets into TestPDF.htm?

My understanding is that the ASP.NET user account will not have the rights to logon locally. It also needs to have the correct file permissions to access the executable and to write to the file system. You need to edit the local security policy and let the ASP.NET user account (maybe ASPNET) logon locally (it may be in the deny list by default). Then you need to edit the permissions on the NTFS filesystem for the other files. If you are in a shared hosting environment it may be impossible to apply the configuration you need.

The best way to use an external executable like this is to queue jobs from the ASP.NET code and have some sort of service monitor the queue. If you do this you will protect yourself from all sorts of bad things happening. The maintenance issues with changing the user account are not worth the effort in my opinion, and whilst setting up a service or scheduled job is a pain, its just a better design. The ASP.NET page should poll a result queue for the output and you can present the user with a wait page. This is acceptable in most cases.

BrianLy
Hi, understood. Can you suggest a better way?
Sean
MSMQ + Windows Services is the general approach.
Noon Silk
To follow up on that, either search around, or I've described it briefly here: http://stackoverflow.com/questions/1317641/queue-based-background-processing-in-asp-net-mvc-web-application
Noon Silk
MSMQ + Windows Services is a specific approach. You can often implement something with SQL Server if you don't know how to use MSMQ or don't want to take a dependency on it. The general thing to look for is queuing systems, of which MSMQ is just one.
BrianLy
You probably shouldn't give the ASP.NET user account any extra rights, it could be a security issue. If possible you should impersonate for just this action, creating a special account with very limited permissions.
Yuriy Faktorovich
+6  A: 

Make sure you've specified an output path for the PDF that is writeable by the ASP.NET process of IIS running on your server (usually NETWORK_SERVICE I think).

Mine looks like this (and it works):

/// <summary>
/// Convert Html page at a given URL to a PDF file using open-source tool wkhtml2pdf
/// </summary>
/// <param name="Url"></param>
/// <param name="outputFilename"></param>
/// <returns></returns>
public static bool HtmlToPdf(string Url, string outputFilename)
{
 // assemble destination PDF file name
 string filename = ConfigurationManager.AppSettings["ExportFilePath"] + "\\" + outputFilename + ".pdf";

 // get proj no for header
 Project project = new Project(int.Parse(outputFilename));

 var p = new System.Diagnostics.Process();
 p.StartInfo.FileName = ConfigurationManager.AppSettings["HtmlToPdfExePath"];

 string switches = "--print-media-type ";
 switches += "--margin-top 4mm --margin-bottom 4mm --margin-right 0mm --margin-left 0mm ";
 switches += "--page-size A4 ";
 switches += "--no-background ";
 switches += "--redirect-delay 100";

 p.StartInfo.Arguments = switches + " " + Url + " " + filename;

 p.StartInfo.UseShellExecute = false; // needs to be false in order to redirect output
 p.StartInfo.RedirectStandardOutput = true;
 p.StartInfo.RedirectStandardError = true;
 p.StartInfo.RedirectStandardInput = true; // redirect all 3, as it should be all 3 or none
 p.StartInfo.WorkingDirectory = StripFilenameFromFullPath(p.StartInfo.FileName);

 p.Start();

 // read the output here...
 string output = p.StandardOutput.ReadToEnd(); 

 // ...then wait n milliseconds for exit (as after exit, it can't read the output)
 p.WaitForExit(60000); 

 // read the exit code, close process
 int returnCode = p.ExitCode;
 p.Close(); 

 // if 0 or 2, it worked (not sure about other values, I want a better way to confirm this)
 return (returnCode <= 2);
}
MGOwen
+1 Thanks for the code. This is working perfectly for me as well.Have you ever found out more info about the return codes?
Jeremy
No, I couldn't find any info on them. Try the wkhtmltopdf area on Google code. (If this is the answer you used, you can accept it as the answer for other people with the same problem who stumble across this question later)
MGOwen
'return (returnCode <= 2)' should be 'return (returnCode == 0 || returnCode == 2)' because you'll receive '1' if the output file already exists, so check before executing process.
bob
A: 
using System;
using System.Diagnostics;
using System.Web;

public partial class pdftest : System.Web.UI.Page
{
    protected void Page_Load(object sender, EventArgs e)
    {

    }
    private void fn_test()
    {
        try
        {
            string url = HttpContext.Current.Request.Url.AbsoluteUri;
            Response.Write(url);
            ProcessStartInfo startInfo = new ProcessStartInfo();
            startInfo.FileName = 
                @"C:\PROGRA~1\WKHTML~1\wkhtmltopdf.exe";//"wkhtmltopdf.exe";
            startInfo.Arguments = url + @" C:\test"
                 + Guid.NewGuid().ToString() + ".pdf";
            Process.Start(startInfo);
        }
        catch (Exception ex)
        {
            string xx = ex.Message.ToString();
            Response.Write("<br>" + xx);
        }
    }
    protected void btn_test_Click(object sender, EventArgs e)
    {
        fn_test();
    }
}
Peter
+2  A: 

You can tell wkhtmltopdf to send it's output to sout by specifying "-" as the output file. You can then read the output from the process into the response stream and avoid the permissions issues with writing to the file system.

Graham Ambrose
That's a cool idea
MGOwen
Can anyone please give code for this?
Ismail
yes this works. i've posted my code. ty
Hath
+1  A: 

I had the same problem when i tried using msmq with a windows service but it was very slow for some reason. (the process part).

This is what finally worked:

private void DoDownload()
{
    var url = Request.Url.GetLeftPart(UriPartial.Authority) + "/CPCDownload.aspx?IsPDF=False?UserID=" + this.CurrentUser.UserID.ToString();
    var file = WKHtmlToPdf(url);
    if (file != null)
    {
        Response.ContentType = "Application/pdf";
        Response.BinaryWrite(file);
        Response.End();
    }
}

public byte[] WKHtmlToPdf(string url)
{
    var fileName = " - ";
    var wkhtmlDir = "C:\\Program Files\\wkhtmltopdf\\";
    var wkhtml = "C:\\Program Files\\wkhtmltopdf\\wkhtmltopdf.exe";
    var p = new Process();

    p.StartInfo.CreateNoWindow = true;
    p.StartInfo.RedirectStandardOutput = true;
    p.StartInfo.RedirectStandardError = true;
    p.StartInfo.RedirectStandardInput = true;
    p.StartInfo.UseShellExecute = false;
    p.StartInfo.FileName = wkhtml;
    p.StartInfo.WorkingDirectory = wkhtmlDir;

    string switches = "";
    switches += "--print-media-type ";
    switches += "--margin-top 10mm --margin-bottom 10mm --margin-right 10mm --margin-left 10mm ";
    switches += "--page-size Letter ";
    p.StartInfo.Arguments = switches + " " + url + " " + fileName;
    p.Start();

    //read output
    byte[] buffer = new byte[32768];
    byte[] file;
    using(var ms = new MemoryStream())
    {
        while(true)
        {
            int read =  p.StandardOutput.BaseStream.Read(buffer, 0,buffer.Length);

            if(read <=0)
            {
                break;
            }
            ms.Write(buffer, 0, read);
        }
        file = ms.ToArray();
    }

    // wait or exit
    p.WaitForExit(60000);

    // read the exit code, close process
    int returnCode = p.ExitCode;
    p.Close();

    return returnCode == 0 ? file : null;
}

Thanks Graham Ambrose and everyone else.

Hath
A: 

Hi!

Hath, thank you very very much!

I was exactly in the same situation and your solution was my salvation.

Bruno Coelho

Bruno Coelho