ansaurus

Question

Cleaning up PHP.

Answer 1

+5 A:

You can strip all $showpost ="$posts"; statements except for the last:

if ($class == 2 AND $posts >=1) {
    $showpost = "1";
} else if ($class == 3 AND $posts >=2) {
    $showpost = "2";
} else if ($class == 4 AND $posts >=3) {
    $showpost = "3";
} else if ($class == 5 AND $posts >=4) {
    $showpost = "4";
} else if ($class == 6 AND $posts >=5) {
    $showpost = "5";
} else if ($class == 7 AND $posts >=6) {
    $showpost = "6";
} else {
    $showpost ="$posts";
}

Or even summarize it to this:

if ($class >= 2 && $class <= 7 && $posts >= ($class - 1)) {
    $showposts = $class - 1;
} else {
    $showposts = $posts;
}

Gumbo 2009-09-07 08:20:07

you can also remove unnecessary quotes as in $showpost = "$posts"; and $showpost = "1";

Salman A 2009-09-07 08:23:59

Thanks for the summarized version.

Homework 2009-09-07 08:31:15

Answer 2

+2 A:

You can use this, not nice but will work.

if($posts >= ($class - 1) AND $class >= 2 AND $class < 8) { $showpost = $class - 1; }
else { $showpost = $posts; }

martin.malek 2009-09-07 08:20:13

The variables end up as strings in the example code, so you need strval to make it similar.

OIS 2009-09-07 08:22:37

@joey: $post have to be equal or larger then ($class - 1) in every if sentence in example. $class have to be larger then 1 and less then 8. Just put those 3 requirements together and you got the code by martin.

OIS 2009-09-07 08:26:10

Thanks, it's not a nice looking, but it works!

Homework 2009-09-07 08:30:42

Answer 3

+7 A:

if (($class >= 2) && ($class <= 7) && ($posts >= $class - 1))
    $showpost = $class - 1;
else
    $showpost = $posts;

The if is split into two sections:

 if (
     ($class >= 2) && ($class <= 7) // Check $class is between 2 and 7 inclusive

     && ($posts >= $class - 1)) // Check $posts >= $class -1
                                // so if $class is 4 this checks if $posts >= 3

This matches the logic in your original code - it's just a matter of seeing the pattern.

If you need $showpost to be a string (chances are you don't), you can cast to string like this:

$showpost = (string)$showpost;

Greg 2009-09-07 08:20:19

This solution worked, but could you explain this, as it makes no sense to me.

Homework 2009-09-07 08:22:39

`($class >= 2) ` - does that the applicable if-statement body would have done. `$showpost = $posts;` - does what would have happened if none of the if statements were true.

Amber 2009-09-07 08:29:52

Thanks indeed. That helps out a lot.

Homework 2009-09-07 08:30:05

Answer 4

A:

Make a Karnaugh map. Don't avoid "switch" when it actually makes sense.

artificialidiot 2009-09-07 08:26:21

ansaurus

tags:

views:

answers:

Cleaning up PHP.

related questions