views:

989

answers:

2

I'd like to override a method in an Objective C class that I don't have the source to.

I've looked into it, and it appears that Categories should allow me to do this, but I'd like to use the result of the old method in my new method, using super to get the old methods result.

Whenever I try this though, my method gets called, but "super" is nil... Any idea why? I'm doing iPhone development with the XCode 2.2 SDK. I'm definitely working with an instance of a class, and the method of the class is an instance method.

@implementation SampleClass (filePathResolver)
-(NSString*) fullPathFromRelativePath:(NSString*) relPath
{
    NSString *result = [super fullPathFromRelativePath: relPath];

  ... do some stuff with the old result

    return result;
}

Note and clarification: From what I can see in the Apple Docs, it appears to me that this should be allowed?

Categories docs at developer.apple.com: When a category overrides an inherited method, the method in the category can, as usual, invoke the inherited implementation via a message to super. However, if a category overrides a method that already existed in the category's class, there is no way to invoke the original implementation.

+8  A: 

Categories extend the original class, but they don't subclass it, therefore a call to super doesn't find the method.

What you want is called Method Swizzling. But be aware that your code could break something. There's an article on Theocacao written by Scot Stevenson about Method Swizzling in the old Objective-C runtime, Cocoa with Love by Matt Gallagher has an article about Method Swizzling in the new Objective-C 2.0 runtime and a simple replacement for it.

Alternatively, you could subclass the class and then either use the subclass or use + (void)poseAsClass:(Class)aClass to replace the superclass. Apple writes:

A method defined by a posing class can, through a message to super, incorporate the superclass method it overrides.

Be aware that Apple has deprecated poseAsClass: in Mac OS X 10.5.

Georg
I'm somewhat disturbed that there is a programming concept called "swizzling". However, it's an interesting concept.
Brian Postow
As I added as a clarification above, what does this mean from the apple docs?When a category overrides an inherited method, the method in the category can, as usual, invoke the inherited implementation via a message to super. However, if a category overrides a method that already existed in the category's class, there is no way to invoke the original implementation.
Brad Parks
Only, you really don't want method swizzling unless it is the only possible way to solve the problem. Even then, know that swizzling comes along with a bunch of fragility and maintenance issues.
bbum
@ Brad Parks: This means `[super message]` is sent to the superclass, and does not call the overridden method.
Georg
ahhh... got it.... thanks!
Brad Parks
@brian: Apple even does isa swizzling in their implementation of KVO.
Georg
+2  A: 

If you will be coding against this class, simply rename the selector to something your code can use, and call the original selector on self:

@implementation SampleClass (filePathResolver)
-(NSString*) myFullPathFromRelativePath:(NSString*) relPath
{
    NSString *result = [self fullPathFromRelativePath: relPath];

  ... do some stuff with the old result

    return result;
}

If you want to override the default implementation of this selector for that class, you'll need to use the method swizzling approach.

Jason
yeah, I don't control all the code written against that class... so that doesn't quite work for me, but thanks for the suggestion!
Brad Parks