ansaurus

Question

Answer 1

+4 A:

switch ($val) {
    case 1:
    case 2:
    case 3:
        if(!$object->doSomething{$val}()==$goodValue)
        row .= $object->doSomething();
        break;
}

meanstreakuk 2009-09-23 14:15:29

I think that you missed that he was calling a different function for each case. Otherwise this would be a great idea.

Tom 2009-09-23 14:22:54

Note the curly braced $val after doSomething in the if statement in my example - if his example 'as is' is what he requires, my answer would work.

meanstreakuk 2009-09-23 14:25:40

at that point, why even have the switch statement at all?

GSto 2009-09-23 14:32:21

Ok, and for sending me back to the manual to check your code +1

Tom 2009-09-23 14:33:45

@GSto - indeed! +1

meanstreakuk 2009-09-23 14:39:02

I suppoer if $val == 0, we don't want to call doSomething0()...

meanstreakuk 2009-09-23 14:39:42

Answer 2

+1 A:

Why don't you just wrap the entire case in the if loop?

if(!$object->doSomething()==$goodValue) {
    switch ($val) {
        case 1:
            row .= $object->doSomething();
            break;
        case 2:
            row .= $object->doSomething();
            break;
        case 3:
            row .= $object->doSomething();
            break;
    }
}

ryeguy 2009-09-23 14:15:53

sorry I forgot to mention that the function called is not the same in each case.

mnml 2009-09-23 14:17:05

You *did* notice there's actually a different function name in the if statement for each value, right?

paxdiablo 2009-09-23 14:18:24

if the function called in each case is not the same then it s not repetitive. is it?

Kennethvr 2009-09-23 14:18:24

is $goodvalue the same in each case?

ryeguy 2009-09-23 14:18:47

@pax, @kennethvr - before his edit he was calling the same function.

ryeguy 2009-09-23 14:19:22

Answer 3

+1 A:

Without knowing much about what doSomething1/2/3 do it sounds like you need too much information on the internals of $object. It might be worth exposing a function on $object that can take $val instead and doSomething1/2/3 depending on $val internally.

if(!$object->doSomething($val)==$goodValue)
        row .= $object->doSomething();
        break;
}

Martijn Laarman 2009-09-23 14:16:35

Answer 4

+1 A:

switch ($val) {
    case 1:
        $method .= 'method1';
        break;
    case 2:
        $method .= 'method2';
        break;
    case 3:
        $method .= 'method3';
        break;
}
$funcVal = $object->$method();
if(!$funcVal==$goodValue) $row .= $funcVal;

Nicky De Maeyer 2009-09-23 14:17:34

if(!$object->$method()==$goodValue) $row .= $object->$method();I'm trying this

mnml 2009-09-23 14:23:47

ok, but the point remains the same, the action performed is the same, only the method calls differ, so only those should be switched...

Nicky De Maeyer 2009-09-23 14:27:11

But if you are going to perform the same method call 2 times, it's better to store the result...

Nicky De Maeyer 2009-09-23 14:28:31

yeah it worked fine

mnml 2009-09-23 14:30:04

In the examples above can you eliminate the switch altogether by composing $method from the function name and $val?

Jackson 2009-09-24 07:25:58

Answer 5

+1 A:

if isn’t a loop, it’s a condition, you might be confusing some.

as to your question: since you are testing different methods there is no (simple, sane) way of not repeating the if’s. you aren’t after all, they all test different conditions.

knittl 2009-09-23 14:21:02

Answer 6

+1 A:

without assuming continuous method names, or using stuff like call_user_func(), just a slight modification:

switch ($val) {
    case 1:
        $doResult = $object->doSomething1();
        break;
    case 2:
        $doResult = $object->doSomething2();
        break;
    case 3:
        $doResult = $object->doSomething3();
        break;
}
if($doResult !== $goodValue)
    row .= $object->doSomething();

jcinacio 2009-09-23 14:22:49

ansaurus

tags:

views:

answers:

Recurrent if loop in a Switch

related questions