Constructor injection

Question

I know the code is missing (Someone will give negative numbers). But I only want to know how do you solve constructor injection in this situation?

class PresenterFactory
{
public:
  template<class TModel>
    AbstractPresenter<TModel>*
    GetFor(AbstractView<TModel> * view)
    {
      return new PresenterA(view, new FakeNavigator());
    }
};

class ViewA : public AbstractView<ModelA>
{
  static PresenterFactory factory;
public:
  ViewA(AbstractPresenter<ModelA> *presenter = factory.GetFor<ModelA>(this)) :
    AbstractView<ModelA> (presenter)
  {
  }

  // this one is also not working
  // invalid use of ‘class ViewA’
  //  ViewA()
  //  {
  //    this->ViewA(factory.GetFor<ModelA> (this));
  //  }
};

Answer 1

Why not to use two constructors?

// constructor with one argument
ViewA(AbstractPresenter<ModelA> *presenter) : AbstractView<ModelA> (presenter)
{
}

// constructor without arguments
ViewA() : AbstractView<ModelA>(factory.GetFor<ModelA>(this))
{
}

By the way, this pointer is valid only within nonstatic member functions. It should not be used in the initializer list for a base class. The base-class constructors and class member constructors are called before this constructor. In effect, you've passed a pointer to an unconstructed object to another constructor. If those other constructors access any members or call member functions on this, the result will be undefined. You should not use the this pointer until all construction has completed.