views:

828

answers:

10

So, I have an interface with a bunch of methods that need to be implemented, the method names are irrelevant.

The objects that implement this interface are often put into collections, and also have a special toString() format that I want them to use.

So, I thought it would be convenient to put hashCode(), equals(), and toString() into the interface, to make sure that I remember to override the default method for these. But when I added these methods to the interface, the IDE/Compiler doesn't complain if I don't have those three methods implemented, even though I explicitly put them in the interface.

Why won't this get enforced for me? It complains if I don't implement any of the other methods, but it doesn't enforce those three. What gives? Any clues?

disclaimer: I am really worried this is a really stupid question, but I am at a loss as to why this doesn't work...

+13  A: 

All 3 of those methods are defined by java.lang.Object which is (implicitly) extended by all other classes; therefore default implementations for those methods exist and compiler has nothing to complain about.

ChssPly76
+12  A: 

All objects in Java inherit from java.lang.Object and Object provides default implementations of those methods.

If your interface contains other methods, Java will complain if you don't implement the interface fully by providing an implementation of those methods. But in the case of equals(), hashCode() and toString() (as well as a few others that you didn't mention) the implementation already exists.

One way you might be able to accomplish what you want is by providing a different method in the interface, say, toPrettyString() or something like that. Then you can call that method instead of the default toString() method.

Adam Batkin
Good point about the different method names. I just wish there were a way, with the exception of inheritance, that I could specify that a class is to override the default implementation.
J_Y_C
Isn't that the purpose of inheritance? Why would you want a different mechanism?
matt b
If you could enforce it, that override might just call super.hashCode() anyway.
Kevin Bourrillion
In response to matt b, it is common to define your own version of toString, so that when you print the object you get a coherent answer instead of the hash of the class name, etc. As for hashcode and equals, whenever you use objects in collections, the default implmentations of hashcode and equals doesn't always properly represent what is "meaningfully equal" for your application.
J_Y_C
+5  A: 

There's an implementation for those methods coming all the way from Object.

Tordek
+6  A: 

Any class that implements your interface also extends Object. Object defines hashCode, equals, and toString and has default implementations of all three.

What you are trying to achieve is good, but not practicable.

Steve McLeod
+4  A: 

Your object already contains implementations of those three methods, because every object inherits those methods from Object, unless they are overridden.

Matt Ball
+3  A: 

Java only cares that the methods are defined somewhere. The interface doesn't force you to redefine the methods in new classes that inherit from the interface for the first time if they're already defined. Since java.lang.Object already implements these methods, your new objects conform to the interface even if they don't override these three methods on their own.

Ken Bloom
+3  A: 

Other people have answered your actual question sufficiently. As far as a solution for your particular problem, you might consider creating your own methods (maybe getStringRepresentation, getCustomHashcode, and equalsObject), and have your objects extend a base class whose equals, toString, and hashCode methods call these methods.

This might defeat the purpose of using an interface in the first place, though. This is one of the reasons that some people have suggested that equals, toString, and hashCode should never have been included on the Object class in the first place.

StriplingWarrior
+9  A: 

It sounds like you want to force your classes to override the default implementations of those methods. If so, the way to do this is to declare an abstract superclass that has the methods declared as abstract. For example:

public abstract MyBaseClass implements ... /* existing interface(s) */ {

    public abstract boolean equals(Object other);

    public abstract int hashcode();

    public abstract String toString();
}

Then change your current classes to extend this class.

This approach kind of works, but it is not an ideal solution.

  • It can be problematic for an existing class hierarchy.

  • It is a bad idea to force classes that implement your existing interface to extend a specific abstract class. For example, you can change parameters in method signatures to use the abstract class rather than the existing interface(s). But the end result is less flexible code. (And people can find ways to subvert this anyway; e.g. by adding their own abstract subclass that "implements" the methods with a super.<method>(...) call!)

  • Imposing a particular class heirarchy / implementation pattern can be short sighted, You cannot predict whether some future requirement change will make you regret. That's why people recommend programming against interfaces.

Stephen C
+3  A: 

If you want to force overriding of equals() and hashCode(), extend from an abstract superclass, which defines these methods as abstract.

Bozho
This is the correct way to achieve this. When you have a group of subclasses that you want to share behavior (or in this case, share overriding behavior), use inheritance.
matt b
It is "correct", but it is not without problems - see my answer.
Stephen C
A: 

well if u have declared an interface in which by default all the methods are abstract and u do need to provide the functionality but when u implement it in the subclass, then u provide the implementation right. as you can see that every class is the subclass of one superclass(put simply Object is superclass of all the classes) so if u have a class implementing an interface, u need to provide implementation for the methods. but a thing needs to be remembered here that.

irrespective of, if u didn't declare these methods in the interface, you still had this behavior for the subclass that implemented the interface in the first place.

so if don't declare it, it still will be present and another thing is that since these methods and other methods of Object class are present for all the objects of classes, so there is no need for implementation.

sazamsk